Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Release? #2496

Closed
elwayman02 opened this issue Apr 10, 2023 · 14 comments
Closed

New Release? #2496

elwayman02 opened this issue Apr 10, 2023 · 14 comments

Comments

@elwayman02
Copy link
Contributor

What's the timeline on getting a new stable release of this package? There are a few alpha versions, but it's not clear when v3 is planned to go out. If that's a ways out still, can we get some basic maintenance on the dependencies for the 2.x release series? For example, ember-auto-import v1 is still being required by the latest stable release, when most apps want to be on v2 at this point.

@Duder-onomy
Copy link
Contributor

Duder-onomy commented May 3, 2023

@cah-brian-gantzler Any timeline for a new release? I am waiting on some fixes in the upstream mirage repo, specifically this: #2458.
Anything we can do to help? test alpha versions etc?
🙏 Thanks for all the work.

@cah-brian-gantzler
Copy link
Collaborator

According to the #2458. it was fixed in MirageJS, but hasnt been released (at the time of the comment), would have to look it mirageJS was released, then could bump the version here.

@SergeAstapov was doing a lot of the releases here I think

@cah-brian-gantzler
Copy link
Collaborator

Looks like that fix is in 0.1.46 and 0.1.47 Was wondering how I was using it an its because I pin some versions. So in my app I have this in the package.json (using yarn). This is how I am getting 0.1.47 into my app. As you can see I have to do that for a few other addons that also either need upgraded, or down graded (for example there are addons using ember modifier 4, but since not all are updated, I have to force them down to 3). (I think some of these may have been needed at one time but no longer, ie ember-cli-babel I think can be removed)

  "resolutions": {
    "miragejs": "~0.1.47",
    "@embroider/macros": "^1.10.0",
    "@embroider/util": "^1.10.0",
    "ember-cli-babel": "^7.26.1",
    "ember-modifier": "^3.2.7",
    "@fortawesome/fontawesome-svg-core": "1.2.35"
  }
``

@elwayman02
Copy link
Contributor Author

@cah-brian-gantzler what is currently blocking the alpha versions from being considered stable?

@cah-brian-gantzler
Copy link
Collaborator

I think at the time it was just getting people to use it and see if there was any issues (I have been on the alpha for a long time). Im thinking there is no reason not to.

Given the changes coming in Ember Data and the fact that the create server from Mirage is more exposed now and ember-auto-import, I have been wanting to create a project using Mirage that does not use ember-cli-mirage at all. Not sure what need there is for this addon anymore. Just a personal FYI

@elwayman02
Copy link
Contributor Author

@cah-brian-gantzler I think it would make sense to move forward and release the stable version at this point. Whether or not ember-cli-mirage can be completely replaced by direct miragejs usage is another matter altogether; we should still make sure the last release of this package is stable if and when a decision is made to deprecate it in favor of that approach.

@cah-brian-gantzler
Copy link
Collaborator

@SergeAstapov You were doing a lot of the releases back then, would you have time to make the alpha version a real release?

@Yelinz
Copy link

Yelinz commented Sep 21, 2023

The problem is ember-cli-mirage is in a subdirectory, so for some tools as yarn v1, you cannot even install the latest commit. Not even with a tool like gitpkg

@cah-brian-gantzler
Copy link
Collaborator

You should be able to use Gitpkg. I have in the past for other addons. For addons converted to V2 addon is when you will no longer be able to use gitpkg. Looking at the source this still appears to be a v1

@Yelinz
Copy link

Yelinz commented Sep 22, 2023

"broccoli-merge-trees": "^4.2.0",
"ember-auto-import": "^2.6.1",
"ember-cli-babel": "^8.0.0",

seems v2 to me or am i missing something

Also gitpkg just doesnt seem to work, as it returns a 500. Not sure if the problem is from ember-cli-mirage or gitpkg https://gitpkg.now.sh/miragejs/ember-cli-mirage/packages/ember-cli-mirage?master

@bartocc
Copy link
Contributor

bartocc commented Sep 26, 2023

Hi folks,

What about cutting a new alpha.4 release?
alpha.3 was released in April. Much has happened since!

@SergeAstapov
Copy link
Collaborator

v3.0.0-alpha.5 has been published. Please let me know if you face any issues!

@bartocc
Copy link
Contributor

bartocc commented Oct 2, 2023

Thx @SergeAstapov

@SergeAstapov
Copy link
Collaborator

v3.0.0 is out https://github.com/miragejs/ember-cli-mirage/releases/tag/v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants