Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support default values in rule_types #1657

Open
jhrozek opened this issue Nov 15, 2023 · 1 comment · May be fixed by #4953
Open

Support default values in rule_types #1657

jhrozek opened this issue Nov 15, 2023 · 1 comment · May be fixed by #4953
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage priority: medium Medium Priority

Comments

@jhrozek
Copy link
Contributor

jhrozek commented Nov 15, 2023

We add default values in rule_types but the gojsonschema library we use doesn't support setting default values and upstream is not open to adding that support.
Having defaults would simplify writing profiles and we should consider adding the support for defaults ourselves.
@jhrozek jhrozek added enhancement New feature or request priority: medium Medium Priority labels Nov 15, 2023
@evankanderson evankanderson added the P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage label May 22, 2024
@evankanderson
Copy link
Member

We're going to close this and see if users have complaints.

@JAORMX JAORMX linked a pull request Nov 12, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request P2 Nice to fix: non-critical items that should be evaluated and planned during issue triage priority: medium Medium Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rule Type schema validation: change library and apply defaults JAORMX/minder
2 participants
@jhrozek @evankanderson