Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite Headers #872

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

rewrite Headers #872

wants to merge 14 commits into from

Conversation

mimmi20
Copy link
Owner

@mimmi20 mimmi20 commented Jan 13, 2025

No description provided.

@mimmi20 mimmi20 added the bc break BC Break label Jan 13, 2025
@mimmi20 mimmi20 self-assigned this Jan 13, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2025
Copy link

github-actions bot commented Jan 13, 2025

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

composer.json

PackageVersionLicenseIssue Type
laminas/laminas-json>= 3.7.1, < 4.0.0NullUnknown License
mimmi20/ua-loader-interface>= 4.0.1, < 5.0.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
composer/laminas/laminas-hydrator >= 4.16.0, < 5.0.0 UnknownUnknown
composer/laminas/laminas-json >= 3.7.1, < 4.0.0 UnknownUnknown
composer/laminas/laminas-serializer >= 3.1.0, < 4.0.0 UnknownUnknown
composer/mimmi20/ua-browser-type >= 11.0.0, < 12.0.0 UnknownUnknown
composer/mimmi20/ua-device-type >= 11.0.0, < 12.0.0 UnknownUnknown
composer/mimmi20/ua-generic-request >= 10.0.1, < 11.0.0 UnknownUnknown
composer/mimmi20/ua-loader-interface >= 4.0.1, < 5.0.0 UnknownUnknown
composer/mimmi20/ua-parser-interface >= 2.0.0, < 3.0.0 UnknownUnknown
composer/mimmi20/ua-result >= 12.0.0, < 13.0.0 UnknownUnknown
composer/symplify/phpstan-extensions >= 12.0.1, < 13.0.0 UnknownUnknown

Scanned Files

  • composer.json

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 86.06463% with 483 lines in your changes missing coverage. Please review.

Project coverage is 89.21%. Comparing base (7bdbf20) to head (a956bb9).

Files with missing lines Patch % Lines
src/Loader/InitData/Device.php 0.00% 92 Missing ⚠️
src/Loader/InitData/Client.php 0.00% 53 Missing ⚠️
src/Loader/InitData/Os.php 0.00% 45 Missing ⚠️
src/Loader/InitData/Engine.php 0.00% 37 Missing ⚠️
src/Loader/Data/Device.php 0.00% 33 Missing ⚠️
src/Loader/Data/Company.php 0.00% 31 Missing ⚠️
src/Loader/Data/Engine.php 0.00% 31 Missing ⚠️
src/Loader/Data/Os.php 0.00% 31 Missing ⚠️
src/Loader/InitData/Company.php 0.00% 26 Missing ⚠️
src/Loader/DeviceLoader.php 4.34% 22 Missing ⚠️
... and 19 more
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##              master     #872       +/-   ##
==============================================
- Coverage     100.00%   89.21%   -10.79%     
- Complexity       466     3004     +2538     
==============================================
  Files             81      141       +60     
  Lines           1494     4746     +3252     
==============================================
+ Hits            1494     4234     +2740     
- Misses             0      512      +512     
Flag Coverage Δ
php-8.3 89.21% <86.06%> (-10.79%) ⬇️
phpunit 89.21% <86.06%> (-10.79%) ⬇️
ubuntu-24.04 89.21% <86.06%> (-10.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Detector.php 100.00% <100.00%> (ø)
src/DetectorFactory.php 100.00% <100.00%> (ø)
src/Helper/MobileDevice.php 100.00% <100.00%> (ø)
src/Loader/DeviceLoaderFactory.php 96.00% <100.00%> (-4.00%) ⬇️
src/Parser/Header/BaiduFlyflow.php 100.00% <100.00%> (ø)
src/Parser/Header/DeviceStockUaClientCode.php 100.00% <100.00%> (ø)
src/Parser/Header/DeviceStockUaClientVersion.php 100.00% <100.00%> (ø)
src/Parser/Header/DeviceStockUaDeviceCode.php 100.00% <100.00%> (ø)
src/Parser/Header/DeviceStockUaEngineCode.php 100.00% <100.00%> (ø)
src/Parser/Header/DeviceStockUaEngineVersion.php 100.00% <100.00%> (ø)
... and 63 more

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 16180 lines exceeds the maximum allowed for the inline comments feature.

@mimmi20 mimmi20 added the dependencies Pull requests that update a dependency file label Jan 18, 2025
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 19818 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 20927 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 20932 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 21753 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 21542 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 21601 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 21877 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 22153 lines exceeds the maximum allowed for the inline comments feature.

Copy link

codeclimate bot commented Jan 19, 2025

Code Climate has analyzed commit a956bb9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 86.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.2% (-10.7% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc break BC Break dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update ua-device-type to enum based version update ua-browser-type to enum based version
1 participant