Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Channel capabilities to bindings and return the channel to user #34

Open
miketheprogrammer opened this issue Nov 23, 2014 · 1 comment

Comments

@miketheprogrammer
Copy link
Owner

User needs to be able to decide if they want to block on a channel or handle the result instantly instead of through a handler. This gives a little too much control and in the current system could lock up your binding, i.e. User creates a Window binding but calls window.move or some other CallWhenDisplayed method, and blocks on the channel, thinking that it will return, however it will not receive until window.show() has been called.

However with the above mentioned, I think with some warning, we should provide this option.

@tehbilly - Feel free to chime in here :)

@tehbilly
Copy link
Collaborator

I think that would be best handled either by passing in a channel you'd want to be notified on, or by passing in an instance of the handler that is controlled by the go-thrust system. I like the channel approach, personally, as it's more flexible. I'd honestly have to sit down and try the different implementations in a test to see which made more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants