Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and Handle 500 error from NASA API #26

Open
mikelax opened this issue Jan 31, 2017 · 2 comments
Open

Catch and Handle 500 error from NASA API #26

mikelax opened this issue Jan 31, 2017 · 2 comments
Assignees
Labels

Comments

@mikelax
Copy link
Owner

mikelax commented Jan 31, 2017

As a user, I don't want to see an internal error message when running an apod command, but rather a friendly message of what happened.

example command: /spacebot apod 2009-10-17
This API is returning a 500 error from NASA, this should be caught and return a message to the user that there is a problem returning the image for this specific date, please try a different date.

We should catch errors from NASA for all APIs, not just apod.

@mikelax mikelax self-assigned this Jan 31, 2017
@mikelax mikelax added the Hacktoberfest Hacktoberfest label Oct 1, 2018
@jantznick
Copy link

Is there still a need for this? Would be happy to help out!

@mikelax
Copy link
Owner Author

mikelax commented Oct 5, 2019

@jantznick yeah if you want to take a shot at this, that would be great.
I would think that if the request was for a random image, then we could just generate a new date automatically without needing to alert the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants