-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PlaneFinder to find planes in complex frames #44
Comments
A first pass of this is in #109 - where we at least find the plane and only sample from points in that plane - this really only works when > 75-80% of the frame is the plane of interest |
#124 implements the normal vector alignment - although not in an arbitrary frame. |
#191 drastically speeds up the plane finder |
While the normal does need to be specified in the same transform frame that the limits are, this seems to actually be a decent setup. I was able to extract the gripper face on the UBR-1 using the following config: gripper_plane_finder:
type: robot_calibration::PlaneFinder
topic: /head_camera/depth_registered/points
camera_info_topic: /head_camera/depth_registered/camera_info
camera_sensor_name: gripper_plane_camera
transform_frame: gripper_link
min_x: 0.02
max_x: 0.1
min_y: -0.15
max_y: 0.15
min_z: 0.0
max_z: 0.15
tolerance: 0.005
points_max: 100
debug: false
ground_plane_finder: |
Right now, the plane finder assumes that all visible points, that are within the bounding box, are part of the plane. This works fine for things like "robot views the ground" -- but if anything else enters the frame, it's problematic. It also doesn't let us handle frames with other items/clutter in them, or do more interesting things like find the face plane of the gripper (which has long been something I've wanted to be able to do).
Proposed improvements to PlaneFinder:
The text was updated successfully, but these errors were encountered: