Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Duplicating a ruler with Black guides produces one with White guides #22

Open
adamellsworth opened this issue Mar 31, 2016 · 4 comments
Labels

Comments

@adamellsworth
Copy link

No description provided.

@mikaa123
Copy link
Owner

mikaa123 commented Apr 1, 2016

Thanks! Will look into it. We might ditch the dark theme in favor of the new light theme #21.

@adamellsworth
Copy link
Author

You're a champ for this app; it's absolutely great!

Thank you for all your hard work.

☀️

@radiovisual
Copy link
Contributor

This is technically still an issue even after the new custom theme features have been merged.

In order to let the duplicated ruler keep the style of the original ruler, we would either need to track the states of each ruler (where the state would include the ruler's theme), or we would have to figure out a way of sending the original ruler's theme to the duplicated ruler once it was created.

Each ruler has it's own updateTheme() method, so it could just be a matter of broadcasting the original ruler's theme to the duplicated ruler, which will update the duplicated ruler's theme.

@mikaa123 mikaa123 added the bug label Jun 14, 2016
@radiovisual
Copy link
Contributor

radiovisual commented Jun 16, 2016

In order to fix this, we have to figure out why electron's window.show() method is not firing. Someone offered some advice regarding the use of electron-connect, so I am leaving a reference to this theory here for discovery.

With the update to the latest Electron, perhaps we will see some different behaviors. I will take a look when I have more free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants