Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support namespace names greater than 60 chars for route endpoint #46

Open
alaypatel07 opened this issue Jul 12, 2021 · 0 comments
Open

Support namespace names greater than 60 chars for route endpoint #46

alaypatel07 opened this issue Jul 12, 2021 · 0 comments
Labels
state-lib

Comments

@alaypatel07
Copy link

The default route controller for OpenShift generates a spec.host value using ${name}-${namespace}.${cluster-subdomain}. When the namespace value is greater than 60 chars, the generated DNS value is invalid. This case is handled in DVM https://github.com/konveyor/mig-controller/blob/55ada42edb55fd056753e9ab69b7eacedc1a7215/pkg/controller/directvolumemigration/rsync.go#L428

The rsync endpoint implementation needs to implement this in order to not break DVM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state-lib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alaypatel07