Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate FormCard prop interface #365

Open
SHA-4 opened this issue Mar 4, 2021 · 1 comment
Open

Inaccurate FormCard prop interface #365

SHA-4 opened this issue Mar 4, 2021 · 1 comment

Comments

@SHA-4
Copy link
Contributor

SHA-4 commented Mar 4, 2021

I get a TypeScript error when passing showControls={false} to FormCard, even though it is an acceptable prop to pass down to Form. It looks like showControls is added to IFormProps and FormCard uses the base ISharedFormProps instead.

Unsure if other tweaks to these prop interfaces are necessary. This is low priority, since it's an easy local fix.
@SHA-4
Copy link
Contributor Author

SHA-4 commented Mar 4, 2021

This also looks to be an issue with setRefFormManager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SHA-4