Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing commands for new AuditLogQuery endpoint #3051

Open
mmascolino opened this issue Dec 11, 2024 · 2 comments · May be fixed by #3066
Open

Missing commands for new AuditLogQuery endpoint #3051

mmascolino opened this issue Dec 11, 2024 · 2 comments · May be fixed by #3066

Comments

@mmascolino
Copy link
Contributor

Describe the bug

#2961 describes removing assorted Get-MgBetaSecurityAuditLog* commands with a comment to use the methods listed here:
https://learn.microsoft.com/en-us/graph/api/resources/security-auditlogquery?view=graph-rest-beta

which is just standard http api documentation for the graph. I would expect that the powershell graph api would have full coverage for the auditLogQuery endpoint. As of now these commands do exist:

> get-command *-MgBetaSecurityAuditLog*

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Function        New-MgBetaSecurityAuditLogQuery                    2.25.0     Microsoft.Graph.Beta.Security
Function        New-MgBetaSecurityAuditLogQueryRecord              2.25.0     Microsoft.Graph.Beta.Security
Function        Remove-MgBetaSecurityAuditLog                      2.25.0     Microsoft.Graph.Beta.Security
Function        Remove-MgBetaSecurityAuditLogQuery                 2.25.0     Microsoft.Graph.Beta.Security
Function        Remove-MgBetaSecurityAuditLogQueryRecord           2.25.0     Microsoft.Graph.Beta.Security
Function        Update-MgBetaSecurityAuditLog                      2.25.0     Microsoft.Graph.Beta.Security
Function        Update-MgBetaSecurityAuditLogQuery                 2.25.0     Microsoft.Graph.Beta.Security
Function        Update-MgBetaSecurityAuditLogQueryRecord           2.25.0     Microsoft.Graph.Beta.Security/

The Get-* commands are missing. Also the examples remain in the repo:
https://github.com/search?q=repo%3Amicrosoftgraph%2Fmsgraph-sdk-powershell+Get-MgBetaSecurityAuditLogQuery&type=code

Expected behavior

I would expect full fidelity with all the other commands i.e. New-xxx to create a query, Get-xxx to see the status of the inflight query jobs and Get-xxx to retrieve the actual records produced by the audit log query

How to reproduce

Install the latest beta.

Note that the Get-MgBetaSecurityAuditLog* commands are missing

SDK Version

2.25.0 beta

Latest version known to work for scenario above?

this was in a previous version

Known Workarounds

Invoke-MgGraphRequest?

Debug output

Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
@mmascolino mmascolino added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Dec 11, 2024
@timayabi2020 timayabi2020 added Dependency: metadata-issue and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned type:bug A broken experience labels Dec 13, 2024
@timayabi2020
Copy link
Contributor

@mmascolino are you requesting for re-enabling generation of the cmldets from the tagged issue?

@timayabi2020 timayabi2020 added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed Dependency: metadata-issue labels Dec 13, 2024
@mmascolino
Copy link
Contributor Author

yes. i think the PowerShell Graph SDK should have full support for all the Graph entities and endpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants