Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Align snippet generation to specification. #1938

Open
4 tasks
andrueastman opened this issue Feb 8, 2024 · 0 comments
Open
4 tasks

[PHP] Align snippet generation to specification. #1938

andrueastman opened this issue Feb 8, 2024 · 0 comments
Labels
area: php Issues relation to PHP Snippet generation. area: snippets-generation Describes a required fix to the snippet generator

Comments

@andrueastman
Copy link
Member

Specification for snippets should align to the specification available at https://gist.github.com/sebastienlevert/ae40eb334c3d5a9d4cd3f4a06d2b09be and shared document.

In summary, we should update snippets to

  • Have necessary import statements
  • Remove client initialization code
  • Add comments with links
  • Display version of SDK the snippet supports.
This was referenced Feb 8, 2024
Closed
Closed
@andrueastman andrueastman added area: snippets-generation Describes a required fix to the snippet generator area: php Issues relation to PHP Snippet generation. labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: php Issues relation to PHP Snippet generation. area: snippets-generation Describes a required fix to the snippet generator
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrueastman