Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipelines should detect missing zip fields in the manifest #189501

Open
mdanish-kh opened this issue Nov 7, 2024 · 2 comments
Open

Pipelines should detect missing zip fields in the manifest #189501

mdanish-kh opened this issue Nov 7, 2024 · 2 comments
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@mdanish-kh
Copy link
Contributor

Description of the new feature/enhancement

If the installer is zip based, pipelines should validate that InstallerType: zip is specified against the installer in the manifest. It should also validate that NestedInstallerType & NestedInstallerFiles are present in the manifest.

Context

A zip based package was merged in #188685 which didn't contain the appropriate ZIP-based fields. The package still installed successfully as the CLI does not appear to rely on those manifest fields for zip installation. But this caused an issue when updating the package through winget-create. See microsoft/winget-create#559

Proposed technical implementation details (optional)

No response
@mdanish-kh mdanish-kh added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 7, 2024
@mdanish-kh
Copy link
Contributor Author

[Policy] Area-Validation-Pipelines

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage This work item needs to be triaged by a member of the core team. Area-Validation-Pipeline Issues related to the manifest validation pipeline. and removed Needs-Triage This work item needs to be triaged by a member of the core team. labels Nov 7, 2024
@Trenly
Copy link
Contributor

Trenly commented Nov 7, 2024

I don't think the issue is that it didn't validate the fields were present; Rather - it didn't validate that the portable actually was an exe file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Trenly @mdanish-kh