powerplatform_data_loss_prevention_policy added additional validation for default_action_rule_behavior and action_rules when both are empty #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawasile
requested review from
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
…ion_policy-produces-errors-while-successfully-provisioning-dlp-policies
…produces-errors-while-successfully-provisioning-dlp-policies' of https://github.com/microsoft/terraform-provider-power-platform into mawasile/518-powerplatform_data_loss_prevention_policy-produces-errors-while-successfully-provisioning-dlp-policies
…ion_policy-produces-errors-while-successfully-provisioning-dlp-policies
…ion_policy-produces-errors-while-successfully-provisioning-dlp-policies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates and improvements to the Data Loss Prevention Policy functionality, primarily focusing on schema enhancements and validation logic. The most important changes include adding additional validation for
default_action_rule_behaviorandaction_rules, updating the Go module version, and refining the schema attributes by removing redundant descriptions.Validation Enhancements:
default_action_rule_behaviorandaction_rulesare correctly configured when both are empty. (internal/services/dlp_policy/resource_dlp_policy.go)Schema Attribute Refinements:
Descriptionfields from schema attributes inDataLossPreventionPolicyDataSourceandDataLossPreventionPolicyResource. (internal/services/dlp_policy/datasource_dlp_policy.go) [1] [2] [3] [4] [5]MarkdownDescriptionto provide more detailed information and links to relevant documentation. (internal/services/dlp_policy/datasource_dlp_policy.go,internal/services/dlp_policy/resource_dlp_policy.go) [1] [2]Module and Dependency Updates:
1.22.9ingo.modfile. (go.mod)New Helper Functions:
getConnectorGroupfunction to handle conversion of connector attributes. (internal/services/dlp_policy/helpers.go)Configuration Validation:
ValidateConfigmethod inDataLossPreventionPolicyResourceto ensure proper configuration of connectors. (internal/services/dlp_policy/resource_dlp_policy.go)