Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Solution Checker for Managed Environments #116

Open
12 tasks
eduardodfmex opened this issue Nov 7, 2023 · 5 comments
Open
12 tasks

Implement Solution Checker for Managed Environments #116

eduardodfmex opened this issue Nov 7, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request resource terraform resource
Milestone

Comments

@eduardodfmex
Copy link
Contributor

eduardodfmex commented Nov 7, 2023

Solution Checker for Managed environments

Managed environments requires the configuration of Solution checker, You can use solution checker in Managed Environments to enforce rich static analysis checks on your solutions against a set of best practice rules and identify problematic patterns.

Solution Checker enforcement description

Automatically verify solution checker results for security and reliability issues before solution import. Learn more

Solution Checker ask for 3 kinds of enforcement:

• None, Turn off solution checker verification during solution import. You can continue to manually review the results in the solution explorer.
• Warm, Check for security and reliability issues in the solution checker results, but do not block solution import for any issues.
• Block, Check for security and reliability issues in the solution checker results and block the solution from being imported if critical issues are found.

Rule exclusions / Excluded Rules

You can select to exclude solution checker rules from enforcement. For example, a particular rule might take significant time and effort to fix across the solution, but you would still like the rest of the rules to be enforced. Use the Excluded Rules dropdown list to select the rules to exclude from enforcement.

Image

The list contains rule names and descriptions grouped by category and sorted by severity. As a reminder, only critical severity rules block a solution from being imported.

Image

Excluded Rules for Managed Environments
Image

Useful links:
Solution checker enforcement in Managed Environments - Power Platform | Microsoft Learn
Use solution checker to validate your solutions - Power Apps | Microsoft Learn

Resource

  • Resource Name: powerplatform_[your resource name]
  • API documentation:
  • Estimated complexity/effort:
  • Related resources/data sources:

Potential Terraform Configuration

# Sample Terraform config that describes how the new resource might look.

resource "example_resource" {
  name = "example"
  parameter1 = "value1"
  parameter2 = "value2"
}

Definition of Done

  • Data Transfer Objects (dtos)
  • Data Client functions
  • Resource Implementation
  • Resource Added to Provider
  • Unit Tests for Happy Path
  • Unit Tests for error path
  • Acceptance Tests
  • Example in the /examples folder
  • Schema Documentation in code
  • Updated auto-generated provider docs with make docs

Contributions

Do you plan to raise a PR to address this issue?

  • Yes
  • No

See the contributing guide for more information about what's expected for contributions.

@eduardodfmex
Copy link
Contributor Author

@eduardodfmex
Copy link
Contributor Author

@leighatami
Copy link
Contributor

@eduardodfmex can you add more context/information? this looks only partially filled out

@leighatami leighatami added this to the GA milestone Nov 7, 2023
@eduardodfmex eduardodfmex self-assigned this Dec 4, 2023
@eduardodfmex
Copy link
Contributor Author

@leighatami I add more description to this.

@mattdot mattdot modified the milestones: GA, Public Preview Dec 7, 2023
@mattdot mattdot modified the milestones: Public Preview, GA Mar 4, 2024
@webstean
Copy link
Contributor

The provider already allows you to basically enable or disabled the Automatic Solution Check, as per below.

resource "powerplatform_managed_environment" "managed_development" {
  ...
  ## Options available: None, Warn, Block
  solution_checker_mode      = "None"
}

This issue is about fine tuning the exact rules that the Solution Check will actually check, and there are lots of options, so it would be a lot of effort to create, test and document these, for what I think are very edge use-cases. Not sure it is worth the effort IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request resource terraform resource
Projects
None yet
Development

No branches or pull requests

4 participants