Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Update Redis Memory Connector to new Text Search Design #6837

Open
alliscode opened this issue Jun 19, 2024 · 1 comment · May be fixed by #9664
Open

Python: Update Redis Memory Connector to new Text Search Design #6837

alliscode opened this issue Jun 19, 2024 · 1 comment · May be fixed by #9664
Assignees
Labels
Ignite python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)

Comments

@alliscode
Copy link
Member

Text Search ADR is here: #5799

Implement new abstractions
Unit tests
Integration tests
Document any limitations in the implementation
Implement a basic RAG samples
Work with Sofia on a new Blog post
Obsolete the old implementation
Create task to graduate the Text Search Service

@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage and removed triage labels Jun 19, 2024
Copy link

github-actions bot commented Oct 9, 2024

This issue is stale because it has been open for 90 days with no activity.

@github-actions github-actions bot added the stale Issue is stale because it has been open for 90 days with no activity label Oct 9, 2024
@github-actions github-actions bot removed the stale Issue is stale because it has been open for 90 days with no activity label Oct 11, 2024
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Nov 5, 2024
@eavanvalkenburg eavanvalkenburg moved this to Sprint: Planned in Semantic Kernel Nov 6, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2024
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
Adds the vector search pieces to the two Redis collection types
Features vectorized search and vector text search.

Also features a slight change to the storage format for Hashsets since
the existing was wrong because the index was not picking up those
fields, fixed now, but if you have a Redis Hash Collection running, this
will break things.

Closes #6837 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignite python Pull requests for the Python Semantic Kernel sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community)
Projects
Status: Sprint: In Review
Development

Successfully merging a pull request may close this issue.

4 participants