Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rush] Update ci.yml to cache installed dependencies #4794

Open
microsoftly opened this issue Jun 19, 2024 · 2 comments
Open

[rush] Update ci.yml to cache installed dependencies #4794

microsoftly opened this issue Jun 19, 2024 · 2 comments

Comments

@microsoftly
Copy link

Summary

There are no clear examples of how to best cache installed dependencies using rushjs. It would be a boon to both rushstack and developers to be able to check the framework repo's ci.yml to see how to implement a primitive for CI operations.

Repro steps

Repro steps not needed

Details

See summary

Standard questions

Please answer these questions to help us investigate your issue more quickly:

QnA unneeded.

@iclanton
Copy link
Member

It'd probably be pretty straightforward to cache the common/temp/node_modules and common/temp/*/node_modules (for subspaces) folders using the GitHub Actions cache. Dependency install happens pretty quickly in our CI, so we haven't investigated that yet, but if you want to put together a proposed change, we'd probably take it.

Right now we've mostly been investigating using the GitHub Actions cache for builds (see related issue actions/toolkit#1760).

@iclanton iclanton moved this from Needs triage to General Discussions in Bug Triage Jun 19, 2024
@dmichon-msft
Copy link
Contributor

Since we install via pnpm by default, this first becomes a question of the best way to cache package installation for pnpm.

Guidance using this as a reference is to cache the pnpm-store: https://github.com/pnpm/action-setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: General Discussions
Development

No branches or pull requests

3 participants