From bdbe899f22f9831dc491c47dc6809477da654b75 Mon Sep 17 00:00:00 2001
From: Thomas Sparks <69657545+thsparks@users.noreply.github.com>
Date: Wed, 11 Dec 2024 14:32:32 -0800
Subject: [PATCH] Show AI Criteria in Teacher Tool (#10295)

This puts the AI criteria & validation plan in our normal (non-test) catalog for the teacher tool.
---
 common-docs/teachertool/catalog-shared.json   | 24 +++++++++++++++++
 .../teachertool/test/catalog-shared.json      | 27 +------------------
 .../test/validator-plans-shared.json          | 15 +----------
 .../teachertool/validator-plans-shared.json   | 12 +++++++++
 4 files changed, 38 insertions(+), 40 deletions(-)

diff --git a/common-docs/teachertool/catalog-shared.json b/common-docs/teachertool/catalog-shared.json
index 6f34ee61b6a4..f4f2af2f3a6d 100644
--- a/common-docs/teachertool/catalog-shared.json
+++ b/common-docs/teachertool/catalog-shared.json
@@ -1,5 +1,29 @@
 {
     "criteria": [
+        {
+            "id": "499F3572-E655-4DEE-953B-5F26BF0191D7",
+            "use": "ai_question",
+            "template": "Ask AI: ${question}",
+            "description": "Experimental: AI outputs may not be accurate. Use with caution and always review responses.",
+            "docPath": "/teachertool",
+            "maxCount": 5,
+            "tags": ["General"],
+            "requestFeedback": true,
+            "params": [
+                {
+                    "name": "question",
+                    "type": "longString",
+                    "maxCharacters": 1000,
+                    "paths": ["checks[0].question"]
+                },
+                {
+                    "name": "shareid",
+                    "type": "system",
+                    "key": "SHARE_ID",
+                    "paths": ["checks[0].shareId"]
+                }
+            ]
+        },
         {
             "id": "59AAC5BA-B0B3-4389-AA90-1E767EFA8563",
             "use": "block_used_n_times",
diff --git a/common-docs/teachertool/test/catalog-shared.json b/common-docs/teachertool/test/catalog-shared.json
index f8dbe6d15c17..633cf5af3274 100644
--- a/common-docs/teachertool/test/catalog-shared.json
+++ b/common-docs/teachertool/test/catalog-shared.json
@@ -1,28 +1,3 @@
 {
-    "criteria": [
-        {
-            "id": "499F3572-E655-4DEE-953B-5F26BF0191D7",
-            "use": "ai_question",
-            "template": "Ask AI: ${question}",
-            "description": "Experimental: AI outputs may not be accurate. Use with caution and always review responses.",
-            "docPath": "/teachertool",
-            "maxCount": 5,
-            "tags": ["General"],
-            "requestFeedback": true,
-            "params": [
-                {
-                    "name": "question",
-                    "type": "longString",
-                    "maxCharacters": 1000,
-                    "paths": ["checks[0].question"]
-                },
-                {
-                    "name": "shareid",
-                    "type": "system",
-                    "key": "SHARE_ID",
-                    "paths": ["checks[0].shareId"]
-                }
-            ]
-        }
-    ]
+    "criteria": []
 }
diff --git a/common-docs/teachertool/test/validator-plans-shared.json b/common-docs/teachertool/test/validator-plans-shared.json
index 79fb6659c6cd..f0865f8840c3 100644
--- a/common-docs/teachertool/test/validator-plans-shared.json
+++ b/common-docs/teachertool/test/validator-plans-shared.json
@@ -1,16 +1,3 @@
 {
-    "validatorPlans": [
-        {
-            ".desc": "Ask Copilot a question",
-            "name": "ai_question",
-            "threshold": -1,
-            "checks": [
-                {
-                    "validator": "aiQuestion",
-                    "question": "",
-                    "shareId": ""
-                }
-            ]
-        }
-    ]
+    "validatorPlans": []
 }
diff --git a/common-docs/teachertool/validator-plans-shared.json b/common-docs/teachertool/validator-plans-shared.json
index 681c7812ae04..f3dad4d168e3 100644
--- a/common-docs/teachertool/validator-plans-shared.json
+++ b/common-docs/teachertool/validator-plans-shared.json
@@ -294,6 +294,18 @@
                     "blockType": "math_number"
                 }
             ]
+        },
+        {
+            ".desc": "Ask Copilot a question",
+            "name": "ai_question",
+            "threshold": -1,
+            "checks": [
+                {
+                    "validator": "aiQuestion",
+                    "question": "",
+                    "shareId": ""
+                }
+            ]
         }
     ]
 }