Rename a field for clarity

microsoft · Oct 27, 2023 · 5467b78 · 5467b78
1 parent 14b98c8
commit 5467b78
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/kiosk/src/Components/GameSlide.tsx b/kiosk/src/Components/GameSlide.tsx
@@ -25,7 +25,7 @@ const GameSlide: React.FC<IProps> = ({ game }) => {
             const gameId = getEffectiveGameId(game);
             return `url("https://makecode.com/api/${gameId}/thumb")`;
         }
-    }, [game, game?.staticGameId]);
+    }, [game, game?.tempGameId]);
 
     return (
         <div className="gameTile" onClick={handleSlideClick}>

diff --git a/kiosk/src/Services/GameRefreshService.ts b/kiosk/src/Services/GameRefreshService.ts
@@ -31,15 +31,15 @@ async function refreshOneAsync() {
             //console.log(`Refreshing game ${game.id}`);
             const details = await getGameDetailsAsync(game.id);
             if (details) {
-                if (details.id !== game.staticGameId) {
-                    // The static/temporary gameId changed, update local copy of game metadata
+                if (details.id !== game.tempGameId) {
+                    // The temporary gameId changed, update local copy of game metadata
                     dispatch(
                         Actions.updateGame(game.id, {
                             name: safeGameName(details.name),
                             description: safeGameDescription(
                                 details.description
                             ),
-                            staticGameId: details.id,
+                            tempGameId: details.id,
                         })
                     );
                     //console.log(`Refreshed game ${game.id} ${details.name}`);

diff --git a/kiosk/src/Transforms/saveNewGamesAsync.ts b/kiosk/src/Transforms/saveNewGamesAsync.ts
@@ -46,7 +46,7 @@ export async function saveNewGamesAsync(
                 uniqueIdentifier: incoming[shareId].id,
                 date: dateStr(),
                 userAdded: true,
-                staticGameId: gameDetails?.id
+                tempGameId: gameDetails?.id
             };
 
             dispatch(Actions.addGame(newGame));
@@ -62,7 +62,7 @@ export async function saveNewGamesAsync(
                     existing.description = safeGameDescription(
                         gameDetails?.description
                     );
-                    existing.staticGameId = gameDetails?.id;
+                    existing.tempGameId = gameDetails?.id;
                 }
                 existing.date = dateStr();
                 existing.uniqueIdentifier = incoming[shareId].id;

diff --git a/kiosk/src/Types/index.ts b/kiosk/src/Types/index.ts
@@ -1,5 +1,5 @@
 export type GameData = {
-    id: string; // Can be a static/temporary gameId or a permanent gameId
+    id: string; // If this is a persistent share game, this is the persistent game id and `tempGameId` will contain the temporary game id. Otherwise, it's the regular game Id.
     name: string;
     description: string;
     highScoreMode: string;
@@ -8,7 +8,7 @@ export type GameData = {
     userAdded?: boolean;
     deleted?: boolean;
     lastRefreshMs?: number; // The last time we refreshed the game from the backend (applies to user-added, persistent shares only)
-    staticGameId?: string; // If this is a persistent share game, this is the static game Id
+    tempGameId?: string; // If this is a persistent share game, this is the temp game Id
 };
 
 export type HighScore = {

diff --git a/kiosk/src/Utils/index.ts b/kiosk/src/Utils/index.ts
@@ -103,5 +103,5 @@ export function isPersistentGameId(id: string): boolean {
 }
 
 export function getEffectiveGameId(game: GameData): string {
-    return game.staticGameId ?? game.id;
+    return game.tempGameId ?? game.id;
 }