From 42f3450dfa41893d8120f86915a16edfb9e87b23 Mon Sep 17 00:00:00 2001 From: thsparks Date: Wed, 1 May 2024 16:47:37 -0700 Subject: [PATCH] Remove previous variable criteria, which are now redundant --- common-docs/teachertool/catalog-shared.json | 16 ---------- .../teachertool/validator-plans-shared.json | 32 ------------------- 2 files changed, 48 deletions(-) diff --git a/common-docs/teachertool/catalog-shared.json b/common-docs/teachertool/catalog-shared.json index da27adf85b81..883162e77ca0 100644 --- a/common-docs/teachertool/catalog-shared.json +++ b/common-docs/teachertool/catalog-shared.json @@ -20,22 +20,6 @@ } ] }, - { - "id": "D21D76A2-D9FD-4F9B-B0AC-973CB870EA78", - "use": "variable_set", - "template": "At least one custom variable is set", - "docPath": "/teachertool", - "description": "At least one user-defined variable is set to a value.", - "maxCount": 1 - }, - { - "id": "0173898D-8A48-4266-AAB9-CE934471A734", - "use": "variable_accessed", - "template": "At least one variable is accessed", - "docPath": "/teachertool", - "description": "At least one variable's value is read.", - "maxCount": 1 - }, { "id": "7AE7EA2A-3AC8-42DC-89DB-65E3AE157156", "use": "block_comment_used", diff --git a/common-docs/teachertool/validator-plans-shared.json b/common-docs/teachertool/validator-plans-shared.json index 8eaed09d78ff..626e0c67a837 100644 --- a/common-docs/teachertool/validator-plans-shared.json +++ b/common-docs/teachertool/validator-plans-shared.json @@ -86,38 +86,6 @@ } ] }, - { - ".desc": "A variable's value is set", - "name": "variable_set", - "threshold": 1, - "checks": [ - { - "validator": "blocksExist", - "blockCounts": [ - { - "blockId": "variables_set", - "count": 1 - } - ] - } - ] - }, - { - ".desc": "A variable's value is used", - "name": "variable_accessed", - "threshold": 1, - "checks": [ - { - "validator": "blocksExist", - "blockCounts": [ - { - "blockId": "variables_get", - "count": 1 - } - ] - } - ] - }, { ".desc": "A parameter's value is used", "name": "parameter_variable_accessed",