From 05a48fb1e1f24070bb8e886507f842381437922a Mon Sep 17 00:00:00 2001
From: Sarah Rietkerk <sarahnrietkerk@gmail.com>
Date: Tue, 27 Feb 2024 17:32:57 -0800
Subject: [PATCH] split out add notes button, added input for notes

---
 .../src/components/EvalResultDisplay.tsx      | 49 +++++++++++++++----
 teachertool/src/constants.ts                  |  1 +
 2 files changed, 41 insertions(+), 9 deletions(-)

diff --git a/teachertool/src/components/EvalResultDisplay.tsx b/teachertool/src/components/EvalResultDisplay.tsx
index 29f1e628cb3c..a7a395c860d6 100644
--- a/teachertool/src/components/EvalResultDisplay.tsx
+++ b/teachertool/src/components/EvalResultDisplay.tsx
@@ -1,12 +1,13 @@
 import * as React from "react";
-import { useContext } from "react";
+import { useState, useContext } from "react";
 import css from "./styling/EvalResultDisplay.module.scss";
 import { AppStateContext } from "../state/appStateContext";
 import { getCatalogCriteriaWithId } from "../state/helpers";
 import { CriteriaEvaluationResult } from "../types/criteria";
 import { classList } from "react-common/components/util";
 import { Button } from "react-common/components/controls/Button";
-import { Strings } from "../constants";
+import { Strings, Ticks } from "../constants";
+import { Input } from "react-common/components/controls/Input";
 
 
 const ResultsHeader: React.FC = () => {
@@ -25,6 +26,40 @@ const ResultsHeader: React.FC = () => {
     );
 };
 
+interface AddNotesButtonProps {
+    criteriaId: string;
+    setShowInput: (show: boolean) => void;
+}
+
+const AddNotesButton: React.FC<AddNotesButtonProps> = ({ criteriaId, setShowInput }) => {
+    const onAddNotesClicked = async () => {
+        pxt.tickEvent(Ticks.AddResultNotes, { criteriaId });
+        setShowInput(true);
+    };
+    return (
+        <Button
+            className={classList("inline", "add-button")}
+            label={Strings.AddNotes}
+            onClick={onAddNotesClicked}
+            title={Strings.AddNotes}
+            leftIcon="fas fa-plus-circle"
+        />
+    );
+}
+
+const CriteriaResultNotes: React.FC<{}> = () => {
+    return (
+        <div>
+            <Input
+                placeholder={lf("Write your notes here")}
+                ariaLabel={lf("Notes regarding the criteria result")}
+                preserveValueOnBlur={true}
+                autoComplete={false}
+            />
+        </div>
+    )
+}
+
 interface CriteriaResultProps {
     criteriaId: string;
     result: CriteriaEvaluationResult;
@@ -32,6 +67,7 @@ interface CriteriaResultProps {
 }
 
 const CriteriaResult: React.FC<CriteriaResultProps> = ({ criteriaId, result, label }) => {
+    const [showInput, setShowInput] = useState(false);
     return (
         <div className={css["result-block-id"]} key={criteriaId}>
             <p className={css["block-id-label"]}>
@@ -47,13 +83,8 @@ const CriteriaResult: React.FC<CriteriaResultProps> = ({ criteriaId, result, lab
             {result === CriteriaEvaluationResult.Pass && (
                 <p className={css["positive-text"]}>{lf("Looks Good!")}</p>
             )}
-            <Button
-                className={classList("inline", "add-button")}
-                label={Strings.AddNotes}
-                onClick={() => console.log("Add notes getting clicked")}
-                title={Strings.AddNotes}
-                leftIcon="fas fa-plus-circle"
-            />
+            {!showInput && <AddNotesButton criteriaId={criteriaId} setShowInput={setShowInput} />}
+            {showInput && <CriteriaResultNotes />}
         </div>
     );
 }
diff --git a/teachertool/src/constants.ts b/teachertool/src/constants.ts
index a53ab244da48..b793f231dad3 100644
--- a/teachertool/src/constants.ts
+++ b/teachertool/src/constants.ts
@@ -31,6 +31,7 @@ export namespace Ticks {
     export const Autorun = "teachertool.autorun";
     export const AddCriteria = "teachertool.addcriteria";
     export const RemoveCriteria = "teachertool.removecriteria";
+    export const AddResultNotes = "teachertool.addresultnotes";
 }
 
 namespace Misc {