Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pac solution sync does not bring down Plugin Package into the source #1073

Open
chrispiasecki opened this issue Nov 4, 2024 · 5 comments
Open
Labels
bug Something isn't working

Comments

@chrispiasecki
Copy link

Describe the bug
When using pac solution sync, a Plugin Package is not being synced and missing in the unpacked solution directory.

To Reproduce
Steps to reproduce the behavior:

  1. Create an empty solution
  2. Clone the solution using pac solution clone
  3. Register a Plugin Package via PRT and add it into the above solution
  4. Register a Plugin Step
  5. Sync the solution using pac solution sync -p Both -a
  6. Observe the pluginpackages directory is not present. The plugin step registered against the plugin package/assembly is present in the SdkMessageProcessingSteps directory.

Expected behavior
Plugin Packages should always be synced.

Desktop (please complete the following information):

  • OS: Windows 11

Additional context
Latest PAC CLI version (1.36.3+g76bcfe6) installed at the time of writing

@chrispiasecki chrispiasecki added the bug Something isn't working label Nov 4, 2024
@ericregnier
Copy link

ericregnier commented Nov 5, 2024

Experiencing the same issue!

Workaround for now is running pac solution export and pac solution unpack
pac solution export -n solname
pac solution unpack -z solname.zip -ad -aw -f src -m Map.xml

@chrispiasecki
Copy link
Author

I resolved the issue - the problem was that I originally had started with a regular plugin assembly, and the unpacked solution still had references to the old plugin assembly and step with the same name prior to converting it to a Plugin Package. I had to manually remove the plugin assembly and plugin step root components in the solution.xml file, and delete the plugin step under the sdkprocessingstep folder. Reran the sync which pulled it down correctly. I imagine it shouldn't be an issue if you started with a plugin package to begin with.

@ericregnier
Copy link

Thanks for that @chrispiasecki! I was hopeful that it would resolve it with these steps but still not working for me.... I only get the SdkMessageProcessingSteps.

Do you mind reopening this bug? It would avoid me creating a new one...

@chrispiasecki chrispiasecki reopened this Nov 6, 2024
@stas-sultanov
Copy link

stas-sultanov commented Nov 7, 2024

Same here.

pac solution clone does clone pluginpackages

pac solution sync does sync pluginpackages if only *.cdsproj does not contain reference to Plugin.csproj

pac solution sync does not sync pluginpackages if only *.cdsproj contain reference to Plugin.csproj and removes pluginpackages if they exist

@stas-sultanov
Copy link

@ericregnier tell please what map.xml you use in your workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants