Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identifier enquoting not implemented (JDBC 4.3) #2450

Open
peterhalicky opened this issue Jun 12, 2024 · 1 comment
Open

identifier enquoting not implemented (JDBC 4.3) #2450

peterhalicky opened this issue Jun 12, 2024 · 1 comment
Labels
Backlog The topic in question has been recognized and added to development backlog Enhancement An enhancement to the driver. Lower priority than bugs.

Comments

@peterhalicky
Copy link

peterhalicky commented Jun 12, 2024

Driver version

12.6.2.jre11 (and any older)

Problem description

Statement.enquoteIdentifier() is a JDBC 4.3 method that enquotes an identifier. Class SQLServerStatement does not implement this method, thus default method from java.sql.Statement is used. This method, however, does not correctly handle identifiers that are already enquoted using square brackets. [table] is a valid identifier, but it gets enquoted to "[table]" which isn't.

Expected behavior

enquoteIdentifier for [table] should return either [table] or "table".

Actual behavior

enquoteIdentifier for [table] returns "[table]"

@lilgreenbird lilgreenbird added the Enhancement An enhancement to the driver. Lower priority than bugs. label Jun 12, 2024
@lilgreenbird
Copy link
Contributor

hi @peterhalicky

thanks for bringing this to our attention I see this was not in java 8 before was added in java 9. I will add this as an enhancement it will be considered when we triage features for our next semester.

@lilgreenbird lilgreenbird added the Backlog The topic in question has been recognized and added to development backlog label Jun 19, 2024
@github-project-automation github-project-automation bot moved this to Backlog in MSSQL JDBC Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog The topic in question has been recognized and added to development backlog Enhancement An enhancement to the driver. Lower priority than bugs.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants