Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: official support of UISettings.ColorValuesChanged #9897

Open
fabianoriccardi opened this issue Aug 14, 2024 · 1 comment
Open

Proposal: official support of UISettings.ColorValuesChanged #9897

fabianoriccardi opened this issue Aug 14, 2024 · 1 comment
Labels
area-CoreFramework Issues on fundamental components like UIElement, visibility, etc. feature proposal New feature proposal

Comments

@fabianoriccardi
Copy link

fabianoriccardi commented Aug 14, 2024

Proposal: official support of UISettings.ColorValuesChanged

Summary

Currently the API UISettings.ColorValuesChanged works only for specific configurations, but in general it is not supported (docs). It would be great having the support for the developers of Windows App SDK and MAUI.

Rationale

  1. The feature should be added to ease the developers and to avoid the "tricks" proposed in UISettings.ColorValuesChanged not fired #9372.
  2. UISettings.ColorValuesChanged was introduced with UWP, so it will ease the migration from UWP to new frameworks.

Scope

Capability Priority
This proposal will allow developers to use ColorValuesChanged as they were used to in UWP Must
@fabianoriccardi fabianoriccardi added the feature proposal New feature proposal label Aug 14, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Aug 14, 2024
@jschroedl
Copy link

jschroedl commented Aug 14, 2024

Came here to add my vote as someone working on a classic Desktop Win32 app written with C++. No WinUI 3 involved for me. I want to call a C++/WinRT API to register for an event which will let me know when the theme has changed between Light/Dark. It's a tragedy that this requires tricks today. I need to support Win10 and Win11.

What's most vexing is that this article indicates I should use the ColorValuesChanged event for Win32 apps:
Support Dark and Light themes in Win32 apps

While this document indicates that the event is unsupported for Desktop apps. Any guidance on which is correct?
Windows Runtime APIs not supported in desktop apps

@karkarl karkarl added area-CoreFramework Issues on fundamental components like UIElement, visibility, etc. and removed needs-triage Issue needs to be triaged by the area owners labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-CoreFramework Issues on fundamental components like UIElement, visibility, etc. feature proposal New feature proposal
Projects
None yet
Development

No branches or pull requests

3 participants