Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content dialog is shown behind the TeachingTip when ShouldConstrainToRootBounds="False" #9397

Open
harvinders opened this issue Mar 5, 2024 · 3 comments
Labels
area-TeachingTip bug Something isn't working team-Controls Issue for the Controls team

Comments

@harvinders
Copy link

Describe the bug

Imagine we have an app that when the user attempts to close displays a content dialog to confirm if the user really wanted to close the application and in turn lose the work.

In this application there is a teaching tip to help user understand the application little better.

When the user invoke the teaching tip and attempt to close the application after that.

  1. teaching tip is not dismissed even when light dismiss mode is set to true.
  2. the content dialog that is displayed is displayed, is shown behind the teaching tip.

Steps to reproduce the bug

  1. Click on a UI control to invoke a teaching tip (light dismiss mode enabled)
  2. Click on the app close button (it invokes a dialog box if the user wants to quit the application)
  3. Teaching tip is not dismissed
  4. The content dialog is shown behind the teaching tip, not allowing the use to close the application or read the message properly.

Expected behavior

  1. If the light dismiss mode is set, when user click the close/maximise button the teaching tip should be dismissed
  2. The content dialog should always be shown on top of the teaching tip.

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.5.0: 1.5.240227000

Windows version

Windows 10 (21H2): Build 19044

Additional context

No response

@harvinders harvinders added the bug Something isn't working label Mar 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@harvinders harvinders changed the title TeachingTip is shown behind the content dialog Content dialog is shown behind the TeachingTip Mar 5, 2024
@codendone codendone added area-TeachingTip team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Apr 5, 2024
@ranjeshj
Copy link
Contributor

ranjeshj commented Apr 9, 2024

In the light dismiss teaching tip case, I would have expected the content dialog to take focus and cause the teaching tip to dismiss. Do you see the content dialog getting focus?

@harvinders
Copy link
Author

harvinders commented Apr 20, 2024

@ranjeshj

The issue is only reproduced when the TeachingTip has ShouldConstrainToRootBounds="False"

image

Looking at the content dialog, I can't make out if it is in focus. However, when I press the Enter the dialog is closed. Also, when I press tab, the button shows focus border around the buttons. So, I suppose the content dialog is in focus.

@harvinders harvinders reopened this Apr 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added needs-triage Issue needs to be triaged by the area owners and removed needs-triage Issue needs to be triaged by the area owners labels Apr 20, 2024
@harvinders harvinders changed the title Content dialog is shown behind the TeachingTip Content dialog is shown behind the TeachingTip when ShouldConstrainToRootBounds="False" Apr 20, 2024
@codendone codendone removed the needs-triage Issue needs to be triaged by the area owners label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TeachingTip bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants