AnimatedIcon Catastrophic Failure when Unloaded from Visual Tree

[michael-hawker]

Describe the bug

Testing things in XAML Studio with the MUXC Expander control, however, when I refresh the view, I disconnect the children first with DisconnectChildrenRecursive. This is causing a crash (catastrophic failure error message), appearing to come from the AnimatedIcon used in the Expander togglebutton style.

Happening on line 35 here after call to VisualTreeHelper.DisconnectChildrenRecursive(...);

microsoft-ui-xaml/dev/AnimatedIcon/AnimatedIcon.cpp

Lines 29 to 35 in da62ad7

	void AnimatedIcon::OnApplyTemplate()
	{
	__super::OnApplyTemplate();
	// Construct the visual from the Source property in on apply template so that it participates
	// in the initial measure for the object.
	ConstructAndInsertVisual();
	auto const panel = winrt::VisualTreeHelper::GetChild(*this, 0).as<winrt::Panel>();

Steps to reproduce the bug

1. Add an Expander to a page.
2. Call VisualTree.DisconnectChildrenRecursive on it.

Expected behavior

No crash, unloads cleanly.

Screenshots

No response

NuGet package version

None

Windows version

Windows 10 (21H2): Build 19044

Additional context

Using 2.7.3 can't upgrade to latest due to PRI issue #8959

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Open similar issues:

• Bug: Random app crash mentions AnimatedIcon, which I'm not directly using anywhere (#6625), similarity score: 0.70

Closed similar issues:

• heap corruption (HR 0xC0000374): AnimatedIconSource (#7310), similarity score: 0.74
• Unreachable code in AnimatedIcon (#5258), similarity score: 0.73

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[michael-hawker]

If I just call panel.Children.Clear() things work as expected, but haven't seen similar problems explicitly calling the VisualTreeHelper before now.