Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoSuggestBox shouldn't be sealed, or NavigationView.AutoSuggestBox should allow templatization #9221

Closed
mfeingol opened this issue Jan 10, 2024 · 2 comments
Labels
area-AutoSuggestBox bug Something isn't working duplicate This issue or pull request already exists team-Controls Issue for the Controls team

Comments

@mfeingol
Copy link

Describe the bug

AutoSuggestBox is sealed and therefore disallows derived classes. The AutoSuggestBox property on the NavigationView requires an AutoSuggestBox and cannot be templatized. Title bar customization is only enabled on Windows 11. Therefore, an app that supports Windows 10 as well as 11 and wants to provide search functionality in the title bar will likely duplicate their ASB in the title bar and in the NavigationView, and enable one or the other depending on OS support. This means any customization and logic used by the ASB will be duplicated in both locations.

Ideally we'd create a user control containing an ASB, or a derived ASB class. But we can do neither in this case.

Steps to reproduce the bug

Read the documentation

Expected behavior

We should be able to user either a UserControl or a derived ASB class.

Screenshots

No response

NuGet package version

WinUI 3 - Windows App SDK 1.4.3: 1.4.231115000

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@mfeingol mfeingol added the bug Something isn't working label Jan 10, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Jan 10, 2024
Copy link

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one. Thank you!

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@bpulliam bpulliam added team-Controls Issue for the Controls team area-AutoSuggestBox and removed needs-triage Issue needs to be triaged by the area owners labels Jan 18, 2024
@ranjeshj
Copy link
Contributor

@mfeingol Thanks for filing the issue. Several types are sealed that we would like to unseal - this is a known problem with WinUI tracked here - #780

@ranjeshj ranjeshj closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
@ranjeshj ranjeshj added the duplicate This issue or pull request already exists label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-AutoSuggestBox bug Something isn't working duplicate This issue or pull request already exists team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

3 participants