Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom panel crashes during hot reload #9212

Open
bizehao opened this issue Jan 7, 2024 · 4 comments
Open

Custom panel crashes during hot reload #9212

bizehao opened this issue Jan 7, 2024 · 4 comments
Labels
area-HotReload bug Something isn't working team-Markup Issue for the Markup team

Comments

@bizehao
Copy link

bizehao commented Jan 7, 2024

Describe the bug

winui3 cpp

I customized a panel. When I run it, I modify the properties of my panel. It is normal and as expected, but when I delete an attribute, it crashes.

This is my layout and my custom panel(yoga:FlexLayout),When I modify the value of Wrap it is normal,But when I remove this Wrap, it crashes
image

Layout after deletion:
image

image

 	0000000000000000()	unknow
 	LeveldbManager.exe!winrt::LeveldbManager::implementation::XamlUserType::ActivateInstance() Line 452	C++
 	LeveldbManager.exe!winrt::impl::produce<winrt::LeveldbManager::implementation::XamlUserType,winrt::Microsoft::UI::Xaml::Markup::IXamlType>::ActivateInstance(void * * result) Line 1004	C++
 	[external code]	
>	LeveldbManager.exe!winrt::impl::consume_Microsoft_UI_Xaml_IApplicationStatics<winrt::Microsoft::UI::Xaml::IApplicationStatics>::Start(const winrt::Microsoft::UI::Xaml::ApplicationInitializationCallback & callback) Line 174	C++
 	LeveldbManager.exe!winrt::Microsoft::UI::Xaml::Application::Start::__l2::<lambda_1>::operator()(const winrt::Microsoft::UI::Xaml::IApplicationStatics & f) Line 12357	C++
 	LeveldbManager.exe!winrt::impl::factory_cache_entry<winrt::Microsoft::UI::Xaml::Application,winrt::Microsoft::UI::Xaml::IApplicationStatics>::call<`winrt::Microsoft::UI::Xaml::Application::Start'::`2'::<lambda_1> &>(winrt::Microsoft::UI::Xaml::Application::Start::__l2::<lambda_1> & callback) Line 6476	C++
 	LeveldbManager.exe!winrt::impl::call_factory<winrt::Microsoft::UI::Xaml::Application,winrt::Microsoft::UI::Xaml::IApplicationStatics,`winrt::Microsoft::UI::Xaml::Application::Start'::`2'::<lambda_1>>(winrt::Microsoft::UI::Xaml::Application::Start::__l2::<lambda_1> && callback) Line 6499	C++
 	LeveldbManager.exe!winrt::Microsoft::UI::Xaml::Application::Start(const winrt::Microsoft::UI::Xaml::ApplicationInitializationCallback & callback) Line 12358	C++
 	[external code]	
	

This all happens in hot reload when xaml is modified

Steps to reproduce the bug

Customize the panel, and then delete some of the added attributes after starting it.

Expected behavior

No response

Screenshots

No response

NuGet package version

None

Windows version

No response

Additional context

No response

@bizehao bizehao added the bug Something isn't working label Jan 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the needs-triage Issue needs to be triaged by the area owners label Jan 7, 2024
@bpulliam bpulliam added team-Markup Issue for the Markup team area-HotReload and removed needs-triage Issue needs to be triaged by the area owners labels Jan 18, 2024
@JesseCol
Copy link

Hi, I'm trying to repro this, but I'm not seeing a crash. Can you please include a minimal repro project? Thanks!

@JesseCol JesseCol added the needs-author-feedback Asked author to supply more information. label Jul 17, 2024
@bizehao
Copy link
Author

bizehao commented Jul 27, 2024

ok, I will upload a demo

@microsoft-github-policy-service microsoft-github-policy-service bot added needs-triage Issue needs to be triaged by the area owners and removed needs-author-feedback Asked author to supply more information. labels Jul 27, 2024
@bizehao
Copy link
Author

bizehao commented Jul 27, 2024

ok, I will upload a demo

@JesseCol JesseCol added needs-author-feedback Asked author to supply more information. and removed needs-triage Issue needs to be triaged by the area owners labels Aug 1, 2024
@bizehao
Copy link
Author

bizehao commented Aug 13, 2024

@microsoft-github-policy-service microsoft-github-policy-service bot added needs-triage Issue needs to be triaged by the area owners and removed needs-author-feedback Asked author to supply more information. no-recent-activity labels Aug 13, 2024
@codendone codendone removed the needs-triage Issue needs to be triaged by the area owners label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-HotReload bug Something isn't working team-Markup Issue for the Markup team
Projects
None yet
Development

No branches or pull requests

4 participants