From e677454cffa8dbaf5cf41daea828c877a40869fc Mon Sep 17 00:00:00 2001 From: Kai Guo Date: Wed, 21 Aug 2019 17:54:08 -0700 Subject: [PATCH] Hover and pressed visual updates (#1171) * Update hover and pressed visuals * Update TreeViewItem to use default CheckBox style * Fix test failure * Update TreeView dragging overlay text style * cr feedbacks --- dev/CheckBox/CheckBox_themeresources.xaml | 94 +++-- dev/CheckBox/TestUI/CheckBoxPage.xaml | 4 +- dev/CommonStyles/Button_themeresources.xaml | 24 +- .../ToggleButton_themeresources.xaml | 16 +- dev/RadioButtons/RadioButton.xaml | 151 ++++++++ .../RadioButton_themeresources.xaml | 170 +++++++++ dev/RadioButtons/RadioButtons.vcxitems | 8 + .../RadioButtons.vcxitems.filters | 2 + .../RadioButtons_themeresources.xaml | 19 +- dev/RadioButtons/TestUI/RadioButtonsPage.xaml | 9 + .../SplitButton_themeresources.xaml | 16 +- dev/TreeView/TreeView.vcxitems | 11 +- dev/TreeView/TreeViewItem.xaml | 243 +------------ dev/TreeView/TreeViewItem_rs1.xaml | 330 ------------------ dev/TreeView/TreeView_rs1_themeresources.xaml | 101 ------ ...rces.xaml => TreeView_themeresources.xaml} | 5 +- 16 files changed, 431 insertions(+), 772 deletions(-) create mode 100644 dev/RadioButtons/RadioButton.xaml create mode 100644 dev/RadioButtons/RadioButton_themeresources.xaml delete mode 100644 dev/TreeView/TreeViewItem_rs1.xaml delete mode 100644 dev/TreeView/TreeView_rs1_themeresources.xaml rename dev/TreeView/{TreeView_rs2_themeresources.xaml => TreeView_themeresources.xaml} (98%) diff --git a/dev/CheckBox/CheckBox_themeresources.xaml b/dev/CheckBox/CheckBox_themeresources.xaml index 6e31ff08af..7fef9f6568 100644 --- a/dev/CheckBox/CheckBox_themeresources.xaml +++ b/dev/CheckBox/CheckBox_themeresources.xaml @@ -46,40 +46,40 @@ - + - - - + + + - - - + + + - + - - - - - - - + + + + + + + - - - - - - - + + + + + + + @@ -226,28 +226,28 @@ - + - + - - - - - + + + + + - + - - - - - - - + + + + + + + @@ -255,11 +255,11 @@ - - - - - + + + + + @@ -372,10 +372,6 @@ - @@ -480,10 +476,6 @@ - diff --git a/dev/CheckBox/TestUI/CheckBoxPage.xaml b/dev/CheckBox/TestUI/CheckBoxPage.xaml index ffd660bbc6..7017b7ba16 100644 --- a/dev/CheckBox/TestUI/CheckBoxPage.xaml +++ b/dev/CheckBox/TestUI/CheckBoxPage.xaml @@ -11,8 +11,10 @@ - + + + diff --git a/dev/CommonStyles/Button_themeresources.xaml b/dev/CommonStyles/Button_themeresources.xaml index 264fa5061d..f3407359bd 100644 --- a/dev/CommonStyles/Button_themeresources.xaml +++ b/dev/CommonStyles/Button_themeresources.xaml @@ -7,20 +7,20 @@ - - + + - + - + 1 - + @@ -28,7 +28,7 @@ - + @@ -81,20 +81,20 @@ - - + + - + - + 1 - + @@ -102,7 +102,7 @@ - + diff --git a/dev/CommonStyles/ToggleButton_themeresources.xaml b/dev/CommonStyles/ToggleButton_themeresources.xaml index cbb22c24c6..65a8d5e397 100644 --- a/dev/CommonStyles/ToggleButton_themeresources.xaml +++ b/dev/CommonStyles/ToggleButton_themeresources.xaml @@ -8,11 +8,11 @@ 1 - + - + @@ -32,11 +32,11 @@ - + - + @@ -122,11 +122,11 @@ 1 - + - + @@ -146,11 +146,11 @@ - + - + diff --git a/dev/RadioButtons/RadioButton.xaml b/dev/RadioButtons/RadioButton.xaml new file mode 100644 index 0000000000..1466b9d6c9 --- /dev/null +++ b/dev/RadioButtons/RadioButton.xaml @@ -0,0 +1,151 @@ + + + + + diff --git a/dev/RadioButtons/RadioButton_themeresources.xaml b/dev/RadioButtons/RadioButton_themeresources.xaml new file mode 100644 index 0000000000..b1787a7060 --- /dev/null +++ b/dev/RadioButtons/RadioButton_themeresources.xaml @@ -0,0 +1,170 @@ + + + + + 1 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 1 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + 1 + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/dev/RadioButtons/RadioButtons.vcxitems b/dev/RadioButtons/RadioButtons.vcxitems index 33c80ca473..a7cf582bd1 100644 --- a/dev/RadioButtons/RadioButtons.vcxitems +++ b/dev/RadioButtons/RadioButtons.vcxitems @@ -35,6 +35,14 @@ RS1 ThemeResources + + RS1 + DefaultStyle + + + RS1 + ThemeResources + diff --git a/dev/RadioButtons/RadioButtons.vcxitems.filters b/dev/RadioButtons/RadioButtons.vcxitems.filters index e3d4377119..e5f91f4ad9 100644 --- a/dev/RadioButtons/RadioButtons.vcxitems.filters +++ b/dev/RadioButtons/RadioButtons.vcxitems.filters @@ -16,6 +16,8 @@ + + diff --git a/dev/RadioButtons/RadioButtons_themeresources.xaml b/dev/RadioButtons/RadioButtons_themeresources.xaml index 80f32afdf5..f2f9f524de 100644 --- a/dev/RadioButtons/RadioButtons_themeresources.xaml +++ b/dev/RadioButtons/RadioButtons_themeresources.xaml @@ -3,18 +3,7 @@ xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:local="using:Microsoft.UI.Xaml.Controls"> - - - 1 - - - 1 - - - 1 - - - + - - @@ -367,12 +137,13 @@ VerticalAlignment="Center" HorizontalAlignment="Center" Background="{ThemeResource SystemControlBackgroundAccentBrush}" - BorderThickness="2" + BorderThickness="1" BorderBrush="{ThemeResource SystemControlBackgroundChromeWhiteBrush}" CornerRadius="{ThemeResource ControlCornerRadius}"> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/dev/TreeView/TreeView_rs1_themeresources.xaml b/dev/TreeView/TreeView_rs1_themeresources.xaml deleted file mode 100644 index 44b966a434..0000000000 --- a/dev/TreeView/TreeView_rs1_themeresources.xaml +++ /dev/null @@ -1,101 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 2,1 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 2,1 - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 2,1 - - - - 32 - \ No newline at end of file diff --git a/dev/TreeView/TreeView_rs2_themeresources.xaml b/dev/TreeView/TreeView_themeresources.xaml similarity index 98% rename from dev/TreeView/TreeView_rs2_themeresources.xaml rename to dev/TreeView/TreeView_themeresources.xaml index bfadebdac1..5929d930b9 100644 --- a/dev/TreeView/TreeView_rs2_themeresources.xaml +++ b/dev/TreeView/TreeView_themeresources.xaml @@ -35,6 +35,7 @@ 1 + 32 @@ -65,6 +66,7 @@ 1 + 32 @@ -95,7 +97,8 @@ 1 + 32 - \ No newline at end of file +