From 9351512dc032270afe48e906184d89a0a76a24ea Mon Sep 17 00:00:00 2001 From: Canhua Li Date: Fri, 18 Feb 2022 14:07:15 -0800 Subject: [PATCH] Add comments to help investigate crashes in UpdateSource when UpdateAcrylicBrushesDarkTheme (#6744) --- dev/dll/XamlControlsResources.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dev/dll/XamlControlsResources.cpp b/dev/dll/XamlControlsResources.cpp index 3301e3a1c8..a7629985ae 100644 --- a/dev/dll/XamlControlsResources.cpp +++ b/dev/dll/XamlControlsResources.cpp @@ -142,6 +142,10 @@ void XamlControlsResources::UpdateSource() } catch (winrt::hresult_error const& e) { + // AcrylicBrushes are defined in WUXC other than MUXC, so the resources are quirked. If rs2 or below resources is loaded in OS repo, it crashes here. + // Check TargetPlatformVersion and MaxVersionTested to make sure it's a big number > 16299. For example + // 10.0.17763.0 + // if (e.code() == E_FAIL) { MUX_FAIL_FAST_MSG(e.message().c_str());