From 3b631bd85d3ffacb08e93e299d1d956be591d6ee Mon Sep 17 00:00:00 2001 From: Keith Mahoney <41657372+kmahone@users.noreply.github.com> Date: Mon, 1 Jul 2019 14:44:01 -0700 Subject: [PATCH] Update Min OS Version for MUX to RS2 (#977) --- .github/ISSUE_TEMPLATE/bug_report.md | 1 - README.md | 3 +- .../FrameworkPackage/FrameworkPackage.csproj | 4 +- .../FrameworkPackageContents/AppxManifest.xml | 2 +- .../FrameworkPackage/MakeFrameworkPackage.ps1 | 15 ------ .../NuSpecs/MUXControls-Nuget-Common.targets | 4 +- .../MUXControls-Nuget-FrameworkPackage.props | 8 --- .../MUXControlsFrameworkPackage.nuspec | 1 - dev/dll/Microsoft.UI.Xaml.vcxproj | 19 +------ dev/dll/Microsoft.UI.Xaml.vcxproj.filters | 2 - dev/dll/XamlControlsResources.cpp | 54 ++----------------- test/IXMPTestApp/IXMPTestApp.Shared.projitems | 2 +- test/IXMPTestApp/MSTest/IXMPTestApp.csproj | 2 +- test/IXMPTestApp/MSTest/project.json | 2 +- test/IXMPTestApp/Package.appxmanifest | 2 +- test/IXMPTestApp/TAEF/project.json | 2 +- .../MUXControls.ReleaseTest.Shared.projitems | 2 +- .../NugetPackageTestApp.csproj | 2 +- .../MSTest/MUXControlsTestApp.csproj | 2 +- test/MUXControlsTestApp/MSTest/project.json | 2 +- .../MUXControlsTestApp.Shared.projitems | 2 +- test/MUXControlsTestApp/TAEF/project.json | 2 +- .../MUXControlsTestApp/ThemeResourcesTests.cs | 15 ------ .../MUXControlsTestAppForIslands.csproj | 2 +- .../MUXControlsTestAppForIslands/project.json | 2 +- .../MUXControlsTestAppWPFPackage.wapproj | 2 +- .../Package.appxmanifest | 2 +- .../MUXTestUtilities/MUXTestUtilities.vcxproj | 2 +- test/TestAppCX/TestAppCX.vcxproj | 2 +- 29 files changed, 30 insertions(+), 132 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index fc2f68e791..4610c8c52b 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -37,7 +37,6 @@ NuGet package version: | April 2018 Update (17134) | | | Fall Creators Update (16299) | | | Creators Update (15063) | | -| Anniversary Update (14393) | | | Device form factor | Saw the problem? | diff --git a/README.md b/README.md index 8ee24338f5..f3c49ae515 100644 --- a/README.md +++ b/README.md @@ -61,7 +61,7 @@ You don't need version checks or conditional XAML markup to use WinUI controls o ### Version support -The Microsoft.UI.Xaml 2.2 NuGet package requires your project to have TargetPlatformVersion >= 10.0.18362.0 and TargetPlatformMinVersion >= 10.0.14393.0 when building. +The Microsoft.UI.Xaml 2.2 NuGet package requires your project to have TargetPlatformVersion >= 10.0.18362.0 and TargetPlatformMinVersion >= 10.0.15063.0 when building. Your app's users can be on any of the following supported Windows versions: * Windows Insider Previews @@ -70,7 +70,6 @@ Your app's users can be on any of the following supported Windows versions: * April 2018 Update (17134 aka "Redstone 4") * Fall Creators Update (16299 aka "Redstone 3") * Creators Update (15063 aka "Redstone 2") -* Anniversary Update (14393 aka "Redstone 1") Some features may have a reduced or slightly different user experience on older versions, particularly on builds before 15063. This should not impact overall usability. diff --git a/build/FrameworkPackage/FrameworkPackage.csproj b/build/FrameworkPackage/FrameworkPackage.csproj index f4460d4687..5eb1a6bcf9 100644 --- a/build/FrameworkPackage/FrameworkPackage.csproj +++ b/build/FrameworkPackage/FrameworkPackage.csproj @@ -52,8 +52,8 @@ 14.0 true Windows Store - 10.0.14393.0 - 10.0.10586.0 + 10.0.18362.0 + 10.0.15063.0 10.0 diff --git a/build/FrameworkPackage/FrameworkPackageContents/AppxManifest.xml b/build/FrameworkPackage/FrameworkPackageContents/AppxManifest.xml index 5e77a99506..4c1c9a541c 100644 --- a/build/FrameworkPackage/FrameworkPackageContents/AppxManifest.xml +++ b/build/FrameworkPackage/FrameworkPackageContents/AppxManifest.xml @@ -12,7 +12,7 @@ - + diff --git a/build/FrameworkPackage/MakeFrameworkPackage.ps1 b/build/FrameworkPackage/MakeFrameworkPackage.ps1 index eea30534f3..b7fc29908f 100644 --- a/build/FrameworkPackage/MakeFrameworkPackage.ps1 +++ b/build/FrameworkPackage/MakeFrameworkPackage.ps1 @@ -220,21 +220,6 @@ if ($Configuration -ilike "debug") #$PackageName += ".Debug" } -# On RS1 we do not have support for DefaultStyleResourceUri which enables our controls to point the XAML framework to load -# their default style out of the framework package's versioned generic.xaml. The support exists on RS2 and greater so for -# RS1 we include a generic.xaml in the default app location that the framework looks for component styles and have that -# file just be a pointer to the framework package rs1 generic.xaml. -$rs1_genericxaml = -@" - - - - - -"@ - -Set-Content -Value $rs1_genericxaml $fullOutputPath\rs1_themes_generic.xaml - # Allow single URI to access Compact.xaml from both framework package and nuget package $compactxaml = @" diff --git a/build/NuSpecs/MUXControls-Nuget-Common.targets b/build/NuSpecs/MUXControls-Nuget-Common.targets index 0b68699add..2ce3f6458d 100644 --- a/build/NuSpecs/MUXControls-Nuget-Common.targets +++ b/build/NuSpecs/MUXControls-Nuget-Common.targets @@ -7,8 +7,8 @@ $([System.Version]::Parse('$(TargetPlatformMinVersion)').Build) + Text="Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.15063.0 (current project is $(MicrosoftUIXamlTargetPlatformMinCheckValue))" + Condition="$(MicrosoftUIXamlTargetPlatformMinCheckValue) < 15063" /> $([System.Version]::Parse('$(TargetPlatformVersion)').Build) diff --git a/build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props b/build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props index f39b4454b0..4ad552ebf8 100644 --- a/build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props +++ b/build/NuSpecs/MUXControls-Nuget-FrameworkPackage.props @@ -129,14 +129,6 @@ - - - - - Designer - Microsoft.UI.Xaml\Themes\generic.xaml - - diff --git a/build/NuSpecs/MUXControlsFrameworkPackage.nuspec b/build/NuSpecs/MUXControlsFrameworkPackage.nuspec index ff2085d2f5..0098468ab4 100644 --- a/build/NuSpecs/MUXControlsFrameworkPackage.nuspec +++ b/build/NuSpecs/MUXControlsFrameworkPackage.nuspec @@ -32,7 +32,6 @@ - \ No newline at end of file diff --git a/dev/dll/Microsoft.UI.Xaml.vcxproj b/dev/dll/Microsoft.UI.Xaml.vcxproj index 316d1d4c44..4ee883192c 100644 --- a/dev/dll/Microsoft.UI.Xaml.vcxproj +++ b/dev/dll/Microsoft.UI.Xaml.vcxproj @@ -19,7 +19,7 @@ true Windows Store $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 10.0 x64 @@ -290,11 +290,6 @@ - - Designer - true - Themes\%(Filename)%(Extension) - Designer true @@ -305,16 +300,6 @@ true DensityStyles\%(Filename)%(Extension) - - Designer - true - Themes\%(Filename)%(Extension) - - - Designer - true - Themes\%(Filename)%(Extension) - Designer @@ -483,7 +468,7 @@ - + PackageReference diff --git a/test/IXMPTestApp/MSTest/project.json b/test/IXMPTestApp/MSTest/project.json index 6906f92a7c..6b671aca35 100644 --- a/test/IXMPTestApp/MSTest/project.json +++ b/test/IXMPTestApp/MSTest/project.json @@ -7,7 +7,7 @@ "MSTest.TestFramework": "1.3.2" }, "frameworks": { - "uap10.0.14393": {} + "uap10.0.15063": {} }, "runtimes": { "win10-x86": {}, diff --git a/test/IXMPTestApp/Package.appxmanifest b/test/IXMPTestApp/Package.appxmanifest index d451846236..6b629882c1 100644 --- a/test/IXMPTestApp/Package.appxmanifest +++ b/test/IXMPTestApp/Package.appxmanifest @@ -9,7 +9,7 @@ Assets\StoreLogo.png - + diff --git a/test/IXMPTestApp/TAEF/project.json b/test/IXMPTestApp/TAEF/project.json index f19b37ca69..f635b8f268 100644 --- a/test/IXMPTestApp/TAEF/project.json +++ b/test/IXMPTestApp/TAEF/project.json @@ -6,7 +6,7 @@ "TAEF.Redist.Wlk": "10.31.180822002" }, "frameworks": { - "uap10.0.14393": {} + "uap10.0.15063": {} }, "runtimes": { "win10-x86": {}, diff --git a/test/MUXControlsReleaseTest/MUXControls.ReleaseTest/MUXControls.ReleaseTest.Shared.projitems b/test/MUXControlsReleaseTest/MUXControls.ReleaseTest/MUXControls.ReleaseTest.Shared.projitems index f42e2b62b6..8639731d8b 100644 --- a/test/MUXControlsReleaseTest/MUXControls.ReleaseTest/MUXControls.ReleaseTest.Shared.projitems +++ b/test/MUXControlsReleaseTest/MUXControls.ReleaseTest/MUXControls.ReleaseTest.Shared.projitems @@ -20,7 +20,7 @@ MUXControls.ReleaseTest MUXControls.ReleaseTest $(ReleaseTestSdkVersion) - 10.0.14393.0 + 10.0.15063.0 14 512 {A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} diff --git a/test/MUXControlsReleaseTest/NugetPackageTestApp/NugetPackageTestApp.csproj b/test/MUXControlsReleaseTest/NugetPackageTestApp/NugetPackageTestApp.csproj index ad2d8735cd..3fae22ee82 100644 --- a/test/MUXControlsReleaseTest/NugetPackageTestApp/NugetPackageTestApp.csproj +++ b/test/MUXControlsReleaseTest/NugetPackageTestApp/NugetPackageTestApp.csproj @@ -14,7 +14,7 @@ en-US UAP $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 14 512 {A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} diff --git a/test/MUXControlsTestApp/MSTest/MUXControlsTestApp.csproj b/test/MUXControlsTestApp/MSTest/MUXControlsTestApp.csproj index 1d4f82d73e..bdcba97145 100644 --- a/test/MUXControlsTestApp/MSTest/MUXControlsTestApp.csproj +++ b/test/MUXControlsTestApp/MSTest/MUXControlsTestApp.csproj @@ -12,7 +12,7 @@ PackageReference diff --git a/test/MUXControlsTestApp/MSTest/project.json b/test/MUXControlsTestApp/MSTest/project.json index 9257ae8f2a..e2da8fa941 100644 --- a/test/MUXControlsTestApp/MSTest/project.json +++ b/test/MUXControlsTestApp/MSTest/project.json @@ -8,7 +8,7 @@ "DiffPlex": "1.2.1" }, "frameworks": { - "uap10.0.14393": {} + "uap10.0.15063": {} }, "runtimes": { "win10-x86": {}, diff --git a/test/MUXControlsTestApp/MUXControlsTestApp.Shared.projitems b/test/MUXControlsTestApp/MUXControlsTestApp.Shared.projitems index 6e8608df79..ecda489f96 100644 --- a/test/MUXControlsTestApp/MUXControlsTestApp.Shared.projitems +++ b/test/MUXControlsTestApp/MUXControlsTestApp.Shared.projitems @@ -24,7 +24,7 @@ en-US UAP $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 14 512 {A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} diff --git a/test/MUXControlsTestApp/TAEF/project.json b/test/MUXControlsTestApp/TAEF/project.json index 16a47e0fd8..f2373a9f38 100644 --- a/test/MUXControlsTestApp/TAEF/project.json +++ b/test/MUXControlsTestApp/TAEF/project.json @@ -8,7 +8,7 @@ "Win2D.uwp": "1.22.0" }, "frameworks": { - "uap10.0.14393": {} + "uap10.0.15063": {} }, "runtimes": { "win10-x86": {}, diff --git a/test/MUXControlsTestApp/ThemeResourcesTests.cs b/test/MUXControlsTestApp/ThemeResourcesTests.cs index adf3247917..b9ae6da887 100644 --- a/test/MUXControlsTestApp/ThemeResourcesTests.cs +++ b/test/MUXControlsTestApp/ThemeResourcesTests.cs @@ -131,14 +131,6 @@ public void VerifyOverrides() IdleSynchronizer.TryWait(); } - // These files only apply to MUX, so there's no need to run these tests for WUXC. -#if !BUILD_WINDOWS - //[TestMethod] TODO: Re-enable after fixing bug 17186090. - public void VerifyRS1DefaultStyleDictionariesWereMergedCorrectly() - { - VerifyDictionariesWereMergedCorrectly(GetRS1DefaultStyleDictionaries(), "Microsoft.UI.Xaml/Themes/Generic.xaml"); - } - [TestMethod] public void VerifyRS2DefaultStyleDictionariesWereMergedCorrectly() { @@ -184,12 +176,6 @@ public void Verify19H1DefaultStyleDictionariesWereMergedCorrectly() } } - [TestMethod] - public void VerifyRS1ThemeResourceDictionariesWereMergedCorrectly() - { - VerifyDictionariesWereMergedCorrectly(GetRS1ThemeResourceDictionaries(), "Microsoft.UI.Xaml/Themes/rs1_themeresources.xaml"); - } - [TestMethod] public void VerifyRS2ThemeResourceDictionariesWereMergedCorrectly() { @@ -529,6 +515,5 @@ private bool CompareObjects(object value, object mergedValue, int indentation) } #endregion -#endif } } diff --git a/test/MUXControlsTestAppForIslands/MUXControlsTestAppForIslands.csproj b/test/MUXControlsTestAppForIslands/MUXControlsTestAppForIslands.csproj index 3ff95c000c..5dd8dd09a7 100644 --- a/test/MUXControlsTestAppForIslands/MUXControlsTestAppForIslands.csproj +++ b/test/MUXControlsTestAppForIslands/MUXControlsTestAppForIslands.csproj @@ -15,7 +15,7 @@ en-US UAP $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 14 512 {A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC} diff --git a/test/MUXControlsTestAppForIslands/project.json b/test/MUXControlsTestAppForIslands/project.json index be8ee59567..17e4d6d30f 100644 --- a/test/MUXControlsTestAppForIslands/project.json +++ b/test/MUXControlsTestAppForIslands/project.json @@ -3,7 +3,7 @@ "Microsoft.NETCore.UniversalWindowsPlatform": "5.2.2" }, "frameworks": { - "uap10.0.14393": {} + "uap10.0.15063": {} }, "runtimes": { "win10-x86": {}, diff --git a/test/MUXControlsTestAppWPFPackage/MUXControlsTestAppWPFPackage.wapproj b/test/MUXControlsTestAppWPFPackage/MUXControlsTestAppWPFPackage.wapproj index bd3cfce7af..50d41b85bd 100644 --- a/test/MUXControlsTestAppWPFPackage/MUXControlsTestAppWPFPackage.wapproj +++ b/test/MUXControlsTestAppWPFPackage/MUXControlsTestAppWPFPackage.wapproj @@ -58,7 +58,7 @@ 03f7f4f7-0250-435e-a730-ed82f6a08652 $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 en-US ..\MUXControlsTestAppWPF\MUXControlsTestAppWPF.csproj diff --git a/test/MUXControlsTestAppWPFPackage/Package.appxmanifest b/test/MUXControlsTestAppWPFPackage/Package.appxmanifest index 7217e19ba2..60bbfc63d0 100644 --- a/test/MUXControlsTestAppWPFPackage/Package.appxmanifest +++ b/test/MUXControlsTestAppWPFPackage/Package.appxmanifest @@ -9,7 +9,7 @@ - + diff --git a/test/MUXTestUtilities/MUXTestUtilities.vcxproj b/test/MUXTestUtilities/MUXTestUtilities.vcxproj index 474029c932..20c960ce58 100644 --- a/test/MUXTestUtilities/MUXTestUtilities.vcxproj +++ b/test/MUXTestUtilities/MUXTestUtilities.vcxproj @@ -18,7 +18,7 @@ true Windows Store $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 10.0 110 diff --git a/test/TestAppCX/TestAppCX.vcxproj b/test/TestAppCX/TestAppCX.vcxproj index c2fa6de63f..1a2f414b1d 100644 --- a/test/TestAppCX/TestAppCX.vcxproj +++ b/test/TestAppCX/TestAppCX.vcxproj @@ -12,7 +12,7 @@ true Windows Store $(MuxSdkVersion) - 10.0.14393.0 + 10.0.15063.0 10.0 ..\..\build\MSTest.pfx