Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple glob filters per invocation #32

Open
tristanlabelle opened this issue Mar 18, 2024 · 0 comments
Open

Support multiple glob filters per invocation #32

tristanlabelle opened this issue Mar 18, 2024 · 0 comments

Comments

@tristanlabelle
Copy link

We want to upload both binaries and pdbs to the symbol server since this is required to get full debugging information in WinDBG. Unfortunately we can't upload them in a single call because searchPattern prevents this.

The glob module supports multiple glob filter patterns when delimited by newlines (docs):

const patterns = ['**/tar.gz', '**/tar.bz']
const globber = await glob.create(patterns.join('\n'))

But we can't leverage this with this github action because of the concatenation logic:
const globber = await glob.create(path.join(symbolsFolder, searchPattern)) (here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant