FreeSid() Called Prematurely

[druske]

Calling FreeSid(everoneSid) before calling SetEntriesInAcl() can cause the latter to return ERROR_INVALID_PARAMETER. FreeSid(everyoneSid) should instead be called if the return from DeriveAppContainerSidFromAppContainerName() is not successful (in which case we throw out of the function), and after the call to SetEntriesInAcl().

While the existing code seems to work fine on a desktop Windows 10 system, this issue manifests on Windows 10 IoT Core.

Windows-iotcore-samples/Samples/NTServiceRpc/cpp/Service/Server/RpcServer.cpp

Line 91 in 9536b30

FreeSid(everyoneSid);