Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch-to-zoom crashes app #5

Open
diiq opened this issue Jun 21, 2019 · 2 comments
Open

Pinch-to-zoom crashes app #5

diiq opened this issue Jun 21, 2019 · 2 comments

Comments

@diiq
Copy link

diiq commented Jun 21, 2019

Hi there! It seems like pinch-to-zoom crashes this example app.

Steps to reproduce:

  • Build the app from master
  • Start the app on a touch-enabled device
  • Open an image from the library
  • Zoom in using fingers

Zooming in far enough crashes the app (you don't have to zoom very far — one un-pinch seems to be enough most times).

The exception's error message is "Cannot create CanvasImageSource sized [X BY Y]; MaximumBitmapSizeInPixels for this device is [X - 1]," where X and Y are, I assume, device-specific.

A maximum zoom makes sense, but the app should probably disallow zooming past that point, rather than crashing irrecoverably.

Even not having zoom at all might be better than a sample app that crashes...

@Karl-Bridge-Microsoft
Copy link
Contributor

Thanks @diiq. I'm currently updating the sample, so maybe I can look after this too.

@diiq
Copy link
Author

diiq commented May 13, 2020

I was on a Surface Studio 2 when I encountered the crash, if that helps -- so the screen might have been bigger than the original developer expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants