Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Popup Control Page #1723

Merged
merged 9 commits into from
Jan 14, 2025
Merged

Add Popup Control Page #1723

merged 9 commits into from
Jan 14, 2025

Conversation

Zakariathr22
Copy link
Contributor

@Zakariathr22 Zakariathr22 commented Jan 13, 2025

Description

This pull request introduces a new page for the Popup control, providing an example and details for developers to better understand and utilize the control, main changes are:

  1. Added Popup Control Details in ControlInfoData.json

    • Included a new entry for the Popup control, with relevant descriptions and metadata.
    • Created a New Page for the Popup Control
  2. The page includes an example that demonstrates the Popup control’s capabilities:

    • Light dismissal (IsLightDismissEnabled).
    • Offset positioning (HorizontalOffset and VerticalOffset).
    • Provided detailed comments in the example code for better understanding and usage.

Motivation and Context

Closes #1713

How Has This Been Tested?

Manually Tested

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@niels9001
Copy link
Contributor

/azp run

@niels9001
Copy link
Contributor

@Zakariathr22 Here's a new icon you can use for Popup:
Popup

WinUIGallery/DataModel/ControlInfoData.json Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Outdated Show resolved Hide resolved
WinUIGallery/ControlPages/PopupPage.xaml Show resolved Hide resolved
@Zakariathr22
Copy link
Contributor Author

@Zakariathr22 Here's a new icon you can use for Popup:
Popup

Thanks for this 🚀

@niels9001
Copy link
Contributor

/azp run

@niels9001 niels9001 self-requested a review January 13, 2025 18:03
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!!!

@niels9001 niels9001 merged commit da694b6 into microsoft:main Jan 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include the Popup control in the Gallery app
2 participants