-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Popup Control Page #1723
Merged
Merged
Add Popup Control Page #1723
+196
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
@Zakariathr22 Here's a new icon you can use for |
niels9001
requested changes
Jan 13, 2025
Co-authored-by: Niels Laute <[email protected]>
Co-authored-by: Niels Laute <[email protected]>
…-Gallery into popup-control
Thanks for this 🚀 |
/azp run |
niels9001
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new page for the
Popup
control, providing an example and details for developers to better understand and utilize the control, main changes are:Added Popup Control Details in
ControlInfoData.json
The page includes an example that demonstrates the Popup control’s capabilities:
Motivation and Context
Closes #1713
How Has This Been Tested?
Manually Tested
Screenshots (if appropriate):
Types of changes