-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File scoped namespaces #1700
base: main
Are you sure you want to change the base?
File scoped namespaces #1700
Conversation
FYI @AndrewKeepCoding |
I did. 🙂 |
048d735
to
5f4ff16
Compare
Are you planning to add a .git-blame-ignore-revs file for this PR? |
5b1c533
to
3b20189
Compare
@Marv51 You are right. Thanks. |
When creating a new UserControl, the namespace is before the usings. Is that behavior also the case for you @AndrewKeepCoding ? |
@marcelwgn No on my side. This is what I get: using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Runtime.InteropServices.WindowsRuntime;
using Windows.Foundation;
using Windows.Foundation.Collections;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Controls;
using Microsoft.UI.Xaml.Controls.Primitives;
using Microsoft.UI.Xaml.Data;
using Microsoft.UI.Xaml.Input;
using Microsoft.UI.Xaml.Media;
using Microsoft.UI.Xaml.Navigation;
// To learn more about WinUI, the WinUI project structure,
// and more about our project templates, see: http://aka.ms/winui-project-info.
namespace WinUIApp5
{
public sealed partial class UserControl1 : UserControl
{
public UserControl1()
{
this.InitializeComponent();
}
}
} |
By the way, the item templates are being changed to file scoped namespaces in v1.7-exp2. |
Huh thats very interesting. Would be good to know why the results differ when creating a new UserControl. But that will be fixed with the new templates anyway (though I would have preferred the namespace to preceed usings but thats a different story). This topic aside, looks like there are some merge conflicts which are not surprising though with these changes though. |
3b20189
to
d301dcf
Compare
@marcelwgn Thanks! I fixed the conflicts. |
@@ -0,0 +1,2 @@ | |||
# Switch to file-scoped namespaces | |||
5f4ff16b4bad507c09bd180091ebbb2df3872279 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this work with regard to the fact that PRs get squashed&merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit for this PR, which primarily involves changes in indentation, will be ignored by git-blame. Right?🤔
/azp run |
Description
This PR will switch C# files from block-scoped namespaces to file-scoped namespaces.
Closes #1689.
Motivation and Context
Improves readability.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes