Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextBlocks: fast path or slower path? (property versus content) #1445

Closed
Tracked by #1279
Jay-o-Way opened this issue Feb 8, 2024 · 4 comments
Closed
Tracked by #1279

TextBlocks: fast path or slower path? (property versus content) #1445

Jay-o-Way opened this issue Feb 8, 2024 · 4 comments
Labels
app enhancement Requests for general app improvements help wanted Extra attention is needed

Comments

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Feb 8, 2024 •
edited
Loading

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

<TextBlock Text="Some text" .../> and <TextBlock>Some text.</TextBlock> are both used in (seemingly) the same situations. Let's choose the right version for the situation?

Screenshots

No response

Windows version

Insider Build (xxxxx)

Additional context

https://learn.microsoft.com/windows/apps/design/controls/text-block
@marcelwgn
Copy link
Contributor

marcelwgn commented Feb 13, 2024 •
edited
Loading

I thin kin some PR, this was discussed and the idea was to do it in the future using fastpath where it makes sense but not migrate existing TextBlocks.

@Jay-o-Way
Copy link
Contributor Author

#1279

@Jay-o-Way
Copy link
Contributor Author

You mean you choose to keep the inconsistency?

@marcelwgn
Copy link
Contributor

Back than other things were more important, given we have #1279 I think we could start thinking about this topic again. What do you think @karkarl

@karkarl karkarl moved this to 📋 Backlog in WinUI Gallery Backlog Apr 18, 2024
@karkarl karkarl mentioned this issue Apr 18, 2024
Closed
@karkarl karkarl added good first issue app enhancement Requests for general app improvements and removed needs-triage labels Apr 18, 2024
@karkarl karkarl added help wanted Extra attention is needed and removed good first issue labels Jun 13, 2024
@Jay-o-Way Jay-o-Way closed this as not planned Won't fix, can't repro, duplicate, stale Aug 22, 2024
@karkarl karkarl moved this from 📋 Backlog to ✅ Done in WinUI Gallery Backlog Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app enhancement Requests for general app improvements help wanted Extra attention is needed
Projects
WinUI Gallery Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karkarl @marcelwgn @Jay-o-Way