Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TitleBarHelper still exists in 5.4 #4706

Open
1 of 3 tasks
akshaybabloo opened this issue Aug 14, 2023 · 3 comments
Open
1 of 3 tasks

TitleBarHelper still exists in 5.4 #4706

akshaybabloo opened this issue Aug 14, 2023 · 3 comments
Labels
bug The issue relates to the wizard not working or a problem with the generated code.

Comments

@akshaybabloo
Copy link

Describe the bug

According to #4516 the helper should have been removed in 5.3 but I still see TitleBarHelper.cs file being created and used. Is this supposed to be still useful?

To Reproduce

Create a blank project

Additional context

No response

Applies to the following platforms:

  • WinUI
  • WPF
  • UWP

About your setup

  • Visual Studio Version: 2022 Community
  • Template Studio Wizard Version: 5.4
  • Windows Build: Windows 10 Enterprise 19045.3208
@akshaybabloo akshaybabloo added the bug The issue relates to the wizard not working or a problem with the generated code. label Aug 14, 2023
@Mysterious-Dev
Copy link
Contributor

Mysterious-Dev commented Nov 10, 2023

Yeah, it is ^^. For the 5.5 update (soon as I write this message ), it remains for the adaptation of the TitleBar with the new system introduced with the Windows App SDK 1.4.

52d63a4

@JoySurfer
Copy link

JoySurfer commented Nov 15, 2023

It seems that these function calls in TitleBarHelper are no longer necessary.

//var hwnd = WinRT.Interop.WindowNative.GetWindowHandle(App.MainWindow);
//if (hwnd == GetActiveWindow())
//{
// SendMessage(hwnd, WMACTIVATE, WAINACTIVE, IntPtr.Zero);
// SendMessage(hwnd, WMACTIVATE, WAACTIVE, IntPtr.Zero);
//}
//else
//{
// SendMessage(hwnd, WMACTIVATE, WAACTIVE, IntPtr.Zero);
// SendMessage(hwnd, WMACTIVATE, WAINACTIVE, IntPtr.Zero);
//}

@smadep
Copy link

smadep commented Nov 20, 2023

how to get the 5.5 adapted code then on a solution based on 5.4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue relates to the wizard not working or a problem with the generated code.
Projects
None yet
Development

No branches or pull requests

4 participants