Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OOBE] Align color mode with settings #9987

Closed
htcfreek opened this issue Mar 2, 2021 · 7 comments
Closed

[OOBE] Align color mode with settings #9987

htcfreek opened this issue Mar 2, 2021 · 7 comments
Assignees
Labels
Area-OOBE First time run experience for users Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Mar 2, 2021

📝 Provide a description of the new feature

OOBE should use the same color mode as settings.

image


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Area-OOBE First time run experience for users Idea-Enhancement New feature or request on an existing product labels Mar 2, 2021
@enricogior
Copy link
Contributor

@htcfreek
to be honest, I don't think we should.
OOBE first run happens before the user even open the Settings app, and it should honor the system theme, not the Settings theme.

@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 2, 2021

@enricogior
I think we should initialize on first start with "system default" and the if settings.json exist we should use this setting.
Reason: I set in PT settings the color scheme to dark, open the oobe screen with the link and it's white (if system app setting = white).

@niels9001
Copy link
Contributor

If it's manually activated through Settings (clicking the OOBE button) it would make sense to have the same theme.

@crutkas
Copy link
Member

crutkas commented Mar 2, 2021

Should align to settings, assume the person may launch the OOBE via settings. PT defaults to system default anyways.

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Mar 2, 2021
@crutkas crutkas added the Priority-3 Bug that is low priority label Mar 2, 2021
@htcfreek
Copy link
Collaborator Author

@niels9001
Is this something we should fix in the new Setting UX or better in a different PR?

@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Aug 23, 2021
@niels9001 niels9001 self-assigned this Aug 23, 2021
@niels9001 niels9001 added the Area-User Interface things that regard UX for PowerToys label Aug 23, 2021
@niels9001 niels9001 mentioned this issue Aug 23, 2021
10 tasks
@Aaron-Junker Aaron-Junker added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 23, 2021
@Aaron-Junker
Copy link
Collaborator

Fixed in #12470 and will be integrated in the next major release of PowerToys

@dedavis6797
Copy link
Contributor

Resolved with the release of v0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-OOBE First time run experience for users Area-User Interface things that regard UX for PowerToys Idea-Enhancement New feature or request on an existing product Priority-3 Bug that is low priority Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

6 participants