Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings / OOBE] Upgrade to WinUI 2.6 #9412

Closed
niels9001 opened this issue Feb 2, 2021 · 10 comments
Closed

[Settings / OOBE] Upgrade to WinUI 2.6 #9412

niels9001 opened this issue Feb 2, 2021 · 10 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@niels9001
Copy link
Contributor

📝 Provide a description of the new feature

Just to keep track of it:

Upgrade to WinUI 2.6 for settings: this version contains a lot of visual updates to the default WinUI controls addressing multiple accessibility issues and to be in line with other Fluent toolkits. It should roll out in the coming weeks / months.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@niels9001 niels9001 added Area-User Interface things that regard UX for PowerToys Status-Blocked We can't make progress due to a dependency or issue labels Feb 2, 2021
@niels9001 niels9001 self-assigned this Feb 2, 2021
@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Feb 2, 2021

Hoping winUI 3 will be finished soon though :) On Twitter they say March :)

@mdtauk
Copy link

mdtauk commented Feb 2, 2021

@niels9001 The OOBE will be out of place compared to those WPF UIs which match inbox Xaml and WinUI 2.5 - so maybe you want to consider sticking with the WinUI_2dot5 visual look, if you upgrade to 2.6 until other things can match?

@crutkas
Copy link
Member

crutkas commented Feb 24, 2021

We're viewing this as 'blocked' until their release? correct?

@niels9001
Copy link
Contributor Author

@crutkas I put in Blocked because WinUI 2.6 is not yet stable, with missing styles here and there. Preview packages are out, but we shouldn't migrate (yet). @mdtauk makes another good point that ModernWPF is not yet adopting any of the new styles to be included in 2.6.

This is not related to WinUI 3.

@crutkas
Copy link
Member

crutkas commented Feb 25, 2021

Newb q, can I see an example of the difference

@mdtauk
Copy link

mdtauk commented Feb 25, 2021

Newb q, can I see an example of the difference

An example of some of the new Visual Styles
image

And current buttons, checkboxes, slider
image
image
image

@crutkas
Copy link
Member

crutkas commented Feb 26, 2021

I don't think the diff between the two systems will be drastically different. Us holding back on upgrading WinUI as well as bug fix impact as well from that team.
image

@crutkas
Copy link
Member

crutkas commented Feb 26, 2021

Settings is the only spot that uses WinUI. I think everything is independent enough where the small diffs won't be blaring

@crutkas crutkas removed the Status-Blocked We can't make progress due to a dependency or issue label Mar 2, 2021
@niels9001 niels9001 mentioned this issue Jul 22, 2021
10 tasks
@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Jul 25, 2021
@Aaron-Junker Aaron-Junker added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 23, 2021
@Aaron-Junker
Copy link
Collaborator

Fixed in #12470 and will be integrated in the next major release of PowerToys

@dedavis6797
Copy link
Contributor

Resolved with the release of v0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

6 participants