Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] FZ icon isn't smooth at higher DPI #9176

Closed
Jay-o-Way opened this issue Jan 19, 2021 · 14 comments
Closed

[Settings] FZ icon isn't smooth at higher DPI #9176

Jay-o-Way opened this issue Jan 19, 2021 · 14 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Jay-o-Way
Copy link
Collaborator

Jay-o-Way commented Jan 19, 2021

ℹ Computer information

  • PowerToys version: 29.3
  • PowerToy Utility: Settings
  • Windows build number: 20H2

📝 Provide detailed reproduction steps (if any)

  1. Open Settings -> FancyZones

❌ Actual result

Icon isn't smooth, but blurry.
Small thing though.

📷 Screenshots

FZ icon not smooth

@Jay-o-Way Jay-o-Way added the Issue-Bug Something isn't working label Jan 19, 2021
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jan 19, 2021
@niels9001
Copy link
Contributor

@Jay-o-Way does it render properly in the navigation view on the left? Any specific OS scaling settings?

@Jay-o-Way
Copy link
Collaborator Author

Jay-o-Way commented Jan 20, 2021

The icon in the Nav menu is good.
image

Earlier image was on my desktop, standard 1920x1080 @ 100%.
The following is on my Surface 2736x1824 @ 200%
image

@crutkas
Copy link
Member

crutkas commented Jan 20, 2021

Is this based on using color picker zoom or actual icon? I need a screenshot without using color picker

@crutkas crutkas added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 20, 2021
@enricogior
Copy link
Contributor

enricogior commented Jan 20, 2021

image

image

@crutkas crutkas added the Area-User Interface things that regard UX for PowerToys label Jan 20, 2021
@crutkas crutkas changed the title [Settings] FZ icon isn't smooth (no prio) [Settings] FZ icon isn't smooth at higher DPI Jan 20, 2021
@crutkas crutkas added Cost-Small Small work item - 0-8 hours of work Priority-3 Bug that is low priority labels Jan 20, 2021
@niels9001
Copy link
Contributor

@enricogior It seems that there's some transparency issues going on. Will look into it!

@Jay-o-Way
Copy link
Collaborator Author

Is this based on using color picker zoom or actual icon? I need a screenshot without using color picker

Yes, I used color picker to zoom. But I don't see how that could be causing any change in the (percieved) pixels?

@Jay-o-Way
Copy link
Collaborator Author

Jay-o-Way commented Jan 21, 2021

I see that the Viewbox is 14×14 px and that doesn't seem "usual". Maybe there is some scaling. The scaling method isn't declared inside the Viewbox element.
Also note that my images look different on different displays. (The first - green background - has 1px thick lines around the edge and the second - orange background - 2px lines)

@niels9001
Copy link
Contributor

@Jay-o-Way Could be that the ViewBox is the cause.. We should remove it and keep the PathIcon (and set it's width / height).

@Jay-o-Way
Copy link
Collaborator Author

I'm not sure yet, but I'm guessing that, because you physically can't draw a line that's narrower than an actual pixel, if (any) scaling is supposed to be done on a subpixel level, it will blend the colors instead. Don't know why that Viewbox is there in the first place?

@niels9001
Copy link
Contributor

I did a test with the a Segoe MDL2 icon.

Rendering as a PathIcon:
image

Rendering as a FontIcon:
image

As you can see, icons render way better as a FontIcon. Might make sense to take our vector images and generate a FontIcon for it to see if that solved anything. Will be easier to use as well.

@niels9001
Copy link
Contributor

Using a FontIcon doesn't really improve it..

image

It basically has to do with the way the pixels are laid out, as @Jay-o-Way mentioned. This was designed however based on E138 (in Segoe MDL2).

To conclude, I think this would require adopting a different pixel grid for the icon to be designed and ideally generate an icon font for it. Quite some work, with little benefit in my opinion..

@Jay-o-Way
Copy link
Collaborator Author

Jay-o-Way commented Jan 21, 2021

@niels9001

Using a FontIcon doesn't really improve it..

That's because you still have a 1px line straight through the middle. Something that icon ED35 "Apps" (for example) cleverly avoided, although that doesn't count for all icons. Looking at the list from MS, there they render 64x64-pixel images with 4-pixel width lines. Equivalent to 16x16 with 1 pixel lines, but better resolution.

Suggestion 1

Use the same (colored) icon that's also used in OOBE.

Suggestion 2

Maybe a different file type? Create a new 16x16 version or an icon based 64x64? Creating a version with 2px borders and with/without space between the zones?

16x16 32x32 space/thickness?
image image with space, 1px borders
image image without space, 2px borders

Suggestion 3

Check out (or use) F0E2 "Gridview" or else ED35 "Apps".

This seems like a simple and fair solution to me.

@Jay-o-Way Jay-o-Way mentioned this issue Aug 20, 2021
10 tasks
@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Aug 20, 2021
@niels9001 niels9001 self-assigned this Aug 20, 2021
@niels9001 niels9001 added the Product-Settings The standalone PowerToys Settings application label Aug 20, 2021
@Aaron-Junker Aaron-Junker added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 23, 2021
@Aaron-Junker
Copy link
Collaborator

Fixed in #12470 and will be integrated in the next major release of PowerToys

@dedavis6797
Copy link
Contributor

Resolved with the release of v0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

6 participants