Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Rename crashes on startup while Japanese/Chinese input method is active #30809

Closed
rintrint opened this issue Jan 8, 2024 · 6 comments
Closed
Labels
External Dependency This bug or feature isn't resolved, but it's following an external work item. External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working Product-PowerRename Refers to the PowerRename PowerToy Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)

Comments

@rintrint
Copy link

rintrint commented Jan 8, 2024

Microsoft PowerToys version

0.76.2

Installation method

GitHub

Running as admin

Yes

Area(s) with issue?

PowerRename

Steps to reproduce

Right click any file to open PowerRename.

✔️ Expected Behavior

Definitely not crashing

❌ Actual Behavior

keeps crashing

same problem in #26416, which is closed. But the problem is still there even if I uninstall and then reinstall powertoys.

I thing the only different in my pc is that I am using chinese. My system language is set to chinese. And my Input Method is chinese.

Other Software

No response

@rintrint rintrint added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 8, 2024
@yuyoyuppe yuyoyuppe added Product-PowerRename Refers to the PowerRename PowerToy and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Jan 9, 2024
@yuyoyuppe
Copy link
Contributor

@rintrint Good day, thanks for the report. I've tried switching my system to Chinese simplified and using PowerRename to rename a file with non-unicode characters, but it still didn't crash. Could you please try to find a filename that consistently causes PowerRename to crash?

/needinfo

image

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 9, 2024
@rintrint
Copy link
Author

rintrint commented Jan 9, 2024

@yuyoyuppe Thank you for your reply.
I tried to reproduce my issue in a VM. I found that the problem is input method.
The input methods have this problem:
Japanese when turn on "Use previous version of Microsoft IME"
Chinese(Traditional, Taiwan) when turn on "Use previous version of Microsoft Bopomofo"
Switch input method to one of them, then PowerRename can crash.

I tested it in Windows 10 22H2.
The issue only exists in the input method; the system language and filename does not affect it.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 9, 2024
@yuyoyuppe
Copy link
Contributor

yuyoyuppe commented Jan 9, 2024

@rintrint thanks for the help, I was able to reproduce the crash. This seems to be an internal WinUI issue, so I've posted it there - microsoft/microsoft-ui-xaml#9216.

@yuyoyuppe yuyoyuppe added External Dependency This bug or feature isn't resolved, but it's following an external work item. Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT) and removed Needs-Team-Response An issue author responded so the team needs to follow up labels Jan 9, 2024
@yuyoyuppe yuyoyuppe changed the title Power Rename keeps crashing Power Rename crashes on startup while Japanese/Chinese input method is active Jan 9, 2024
@yuyoyuppe yuyoyuppe added External Dependency-WinUI 3 Dependency on WinUI Resolution-External External issue, unrelated to PowerToys labels Jan 9, 2024
@crutkas
Copy link
Member

crutkas commented Mar 29, 2024

This should be fixed by WinAppSDK 1.5.1 upgrade looking at the internal bug. @yuyoyuppe can we validate?

If so, this should be resolved with .80

@crutkas crutkas added Status-In progress This issue or work-item is under development and removed Resolution-External External issue, unrelated to PowerToys labels Mar 29, 2024
@crutkas
Copy link
Member

crutkas commented Mar 29, 2024

@jaimecbernardo fyi too, i think this is fixed by 1.5.1 upgrade, we just need to validate

@rintrint
Copy link
Author

After I updated to the latest version, the issue never happened again. Thanks.

@Jay-o-Way Jay-o-Way removed Status-In progress This issue or work-item is under development Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels May 5, 2024
@ethanfangg ethanfangg moved this to Done in 0.81 Release Jun 4, 2024
@jaimecbernardo jaimecbernardo added this to the PowerToys 0.81 milestone Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Dependency This bug or feature isn't resolved, but it's following an external work item. External Dependency-WinUI 3 Dependency on WinUI Issue-Bug Something isn't working Product-PowerRename Refers to the PowerRename PowerToy Severity-High Bugs that we consider a blocking issue for release (crashes stuff outside of PT)
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants