Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings; Plugin manager] Improve position of plugin accessibility warning #12861

Closed
htcfreek opened this issue Aug 24, 2021 · 5 comments
Closed
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Aug 24, 2021

With the new settings ux (#12470) we have switched to a new settings ux and updated the styling.


Description of the new feature / enhancement

The warning for incorrect accessibility settings for plugins has a incorrect position. It is placed between the "action command" settings and the "global results" setting.
image

But because this warning is for both settings we should move it after the "global results" setting to be aligned with common styling of Win11.
img01

Scenario when this would be used?

This change is for improving layout.

Supporting information

No response

@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Area-User Interface things that regard UX for PowerToys Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Aug 24, 2021
@htcfreek
Copy link
Collaborator Author

@niels9001, can you please fix this before release. Thanks.

@niels9001
Copy link
Contributor

Looking at this I wonder if the input field shouldn't be disabled if Include in global result is selected. It has no purpose then, right?

@htcfreek
Copy link
Collaborator Author

htcfreek commented Aug 26, 2021

Looking at this I wonder if the input field shouldn't be disabled if Include in global result is selected. It has no purpose then, right?

The use case is to search only for results from this one plugin and not for results from all global plugins.

Example: Mostly you need all search and program results from global plugins. But then there is a special case where you only need the results from search plugin.

I think we should not change behavior here and as I knew this is part of our spec.

@niels9001
Copy link
Contributor

Sure makes sense. But then we'll keep the current position as it should be close to the textbox (ideally using something like:
image

This will hopefully come to WinUI at some point. More appropriate then using an InfoBar.

@niels9001 niels9001 removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 26, 2021
@htcfreek
Copy link
Collaborator Author

Sure makes sense. But then we'll keep the current position as it should be close to the textbox (ideally using something like:
image

This will hopefully come to WinUI at some point. More appropriate then using an InfoBar.

Seems that you mean the other message.

The message I mean is for both setting. I only mean the "no command and global results" warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager
Projects
None yet
Development

No branches or pull requests

2 participants