Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awake] Rename "Off (Passive)" mode #12632

Closed
1 task
dedavis6797 opened this issue Aug 5, 2021 · 7 comments
Closed
1 task

[Awake] Rename "Off (Passive)" mode #12632

dedavis6797 opened this issue Aug 5, 2021 · 7 comments
Assignees
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Issue-Docs Documentation issue that needs to be improved Priority-3 Bug that is low priority Product-Awake Issues regarding the PowerToys Awake utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@dedavis6797
Copy link
Contributor

Microsoft PowerToys version

0.43.0

Running as admin

  • Yes

Area(s) with issue?

Awake

Steps to reproduce

Per the conversation from #12600, the "Off" mode labeling may be misleading. Changing it to "Inactive", "Allow sleeping", or "Don't keep awake" would be more appropriate.

✔️ Expected Behavior

"Inactive", "Allow sleeping", or "Don't keep awake"

❌ Actual Behavior

"Off (Passive)"

Other Software

No response

@dedavis6797 dedavis6797 added Issue-Bug Something isn't working Issue-Docs Documentation issue that needs to be improved Priority-3 Bug that is low priority Cost-Small Small work item - 0-8 hours of work Product-Awake Issues regarding the PowerToys Awake utility labels Aug 5, 2021
@dedavis6797 dedavis6797 added this to the Stability Release milestone Aug 5, 2021
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 5, 2021
@dedavis6797 dedavis6797 removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Aug 5, 2021
@Jay-o-Way
Copy link
Collaborator

Or maybe just remove it. Since it is the exact opposite of the first toggle switch on the page. They have always felt conflicting/redundant to me.

@dedavis6797
Copy link
Contributor Author

@Jay-o-Way are you referring to the "Enable Awake" toggle? If so, these are two separate functionalities.

@Jay-o-Way
Copy link
Collaborator

Then maybe a different solution all together? Right now I'm thinking there is a check box to either show/hide the icon for Power Rename. Maybe that approach is more logical, when it comes to showing the Awake icon in the systray.

@dedavis6797
Copy link
Contributor Author

Ah, I think we're discussing different points. The focus of this issue is just to name the option more appropriately so that users don't interpret the inactive state of Awake as the utility being disabled (unusable).

What you're suggesting to have the option to remove the icon has been suggested before and is on our backlog of enhancements to address in the near future.

@niels9001 niels9001 self-assigned this Aug 5, 2021
@niels9001 niels9001 added the Status-In progress This issue or work-item is under development label Aug 23, 2021
@niels9001 niels9001 mentioned this issue Aug 23, 2021
10 tasks
@Aaron-Junker Aaron-Junker added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 23, 2021
@Aaron-Junker
Copy link
Collaborator

Fixed in #12470 and will be integrated in the next major release of PowerToys

@dedavis6797
Copy link
Contributor Author

It still says "Off (passive)" in the systray, so this isn't done quite yet.

image

@dedavis6797 dedavis6797 removed the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 2, 2021
@niels9001 niels9001 removed their assignment Oct 1, 2021
@crutkas crutkas self-assigned this Nov 19, 2021
@crutkas crutkas added Status-In progress This issue or work-item is under development Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Nov 19, 2021
@crutkas
Copy link
Member

crutkas commented Nov 30, 2021

This is fixed in 0.51. Please head over to our releases and get the update! https://aka.ms/installpowertoys

@crutkas crutkas closed this as completed Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cost-Small Small work item - 0-8 hours of work Issue-Bug Something isn't working Issue-Docs Documentation issue that needs to be improved Priority-3 Bug that is low priority Product-Awake Issues regarding the PowerToys Awake utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

5 participants