Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate - Move summary definitions from protocol-definitions in server to client #4728

Closed
Tracked by #4683
agarwal-navin opened this issue Jan 5, 2021 · 8 comments
Assignees
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup
Milestone

Comments

@agarwal-navin
Copy link
Contributor

Summary protocols such as ISummaryTree, ISummaryHandle, etc. should be part of the client repo. There are a few dependencies that the server repo has on these. These should be investigated to check if they can either be removed or the protocol can be split.

@agarwal-navin agarwal-navin added the area: runtime Runtime related issues label Jan 5, 2021
@agarwal-navin agarwal-navin self-assigned this Jan 5, 2021
@curtisman
Copy link
Member

Is this a dup of #4002 and #4003?

@agarwal-navin
Copy link
Contributor Author

Looks to be a dupe of #4002.

@agarwal-navin
Copy link
Contributor Author

This may actually be a superset of #4002. We should ideally move all of summary protocol definitions to client.

@curtisman
Copy link
Member

curtisman commented Jan 5, 2021

@wes-carlson and I have talked about this before. I don't know if there is another issue that cover all the types in SummaryTree,

@curtisman
Copy link
Member

Related to #4683

@curtisman curtisman added the refactor Code refactoring and cleanup label Jan 8, 2021
@curtisman curtisman added this to the Next milestone Jan 8, 2021
@ghost ghost added the status: stale label Jul 8, 2021
@ghost
Copy link

ghost commented Jul 8, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Jul 16, 2021
@agarwal-navin agarwal-navin reopened this Jul 16, 2021
@ghost ghost removed the status: stale label Jul 16, 2021
@ghost ghost added the status: stale label Jan 12, 2022
@ghost
Copy link

ghost commented Jan 12, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@agarwal-navin
Copy link
Contributor Author

Closing as these interfaces have moved to common libs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup
Projects
None yet
Development

No branches or pull requests

2 participants