r11s-driver: fix prefetch uncaught exceptions #22298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: loader
⯅ @fluid-example/bundle-size-tests: +293 Bytes
Baseline commit: 1a86c7d |
|
This PR has been automatically marked as stale because it has had no activity for 60 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PrefetchDocumentStorageServiceincludes many fire-and-forget API calls. However, it uses thevoidkeyword to mark those as intentionally un-awaited, rather than using.catch(() => {})to explicitly catch and ignore errors. This results in Unhandled Promise Rejection errors that crash the runtime if those API calls fail.To fix this, I'm simply replacing the
voiduses with.catch(() => {}).Resolves #22214
TODO: