-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft.Build.Sql 0.2.4-preview throws error in VS 17.12 and MSBuild, works in dotnet build #518
Comments
What happens if you use |
This error only pops up in VS2022 (v17.11.5) for me, no issues with |
@akdanz You need to use .sqlprojx (SDK style SSDT) in VS 17.12 preview for proper MsBuild.Sdk.Sqlproj support. Pure luck if it works with VS 17.11 |
@ErikEJ, what do you mean by "pure luck"? It worked for us for a long time with different versions 17.x of Visual Studio and MSBuild all the way to version 0.2.3-preview. It only broke with 0.2.4-preview. |
@avivanoff it was never supported.. it is in 17.12 now |
I just installed the VS 17.12 final release. When i installed the SQL sdk project preview it did not let me open up existing .sqlproj database project(The application which this project type is based on was not found. Please try this link for further information: 00d1a9c2-b5f0-4af3-8072-f6c62b433612). I would have assumed it would support .sqlproj for old format and support sdk style in .sqlprojx |
@czb182 It is either or at the moment, sadly! |
@ErikEJ, I am completely confused now. What was not supported? Using Microsoft.Build.Sql SDK with Visual Studio and MSBuild builds? All I know is that after upgrading to 17.12 I cannot use some of our non-SDK-style SQL projects like @czb182 reported, and I cannot update SDK-style SQL projects to 0.2.4-preview. Are you going to fix/support building Microsoft.Build.Sql SDK projects with Visual Studio and MSBuild? |
@czb182, make sure you do not have "SQL Server Data Tools" and "SQL Server Data Tools SDK-Style (Preview)" installed at the same time, see https://developercommunity.visualstudio.com/t/Trying-to-load-SSDT-projects-is-failing/10772324#T-ND10789149. |
Yeah, i just uninstalled preview. I feel like this could have been handled in a better way. I hope DacFx/Visual Studio team can dedicate some resources and wrap this whole feature up quickly. It has been inching along for so long now. I can't tell if there is some huge amount of complexity to this or it just not been prioritized compared to other features. I don't even need a automatic migration from old project format.. Just give support to recognize either or or new format in sqlproj and support appropriately. |
@cbz182 there's a lot of discussion on this thread already - is the recap that the 0.2.4-preview of the SDK isn't working with VS 2022 17.12, only 0.2.3-preview? |
I think it is more of "0.2.4-preview of the SDK isn't working with any version of Visual Studio or MSBuild, only dotnet builds". |
thanks - I've updated the title and we're digging into the issue. as to @czb182's concern that we keep this moving and go as quick as possible with SDK-style projects in VS - there's a lot of complexity to SQL projects (schema compare, object explorer integration) and an additional layer of other VS components with dependencies into SSDT that we're navigating. We're pressing forward with support in VS. |
VS2022 17.11.5
Microsoft.Build.SQL 0.2.4-preview
Can not load Database project, as this error is thrown.
error : The result "" of evaluating the value "$(MicrosoftNETBuildTasksAssembly)" of the "AssemblyFile" attribute in element is not valid. C:\Users\username.nuget\packages\microsoft.build.sql\0.2.4-preview\Sdk\Sdk.targets
This is not happening with 0.2.3-preview
The text was updated successfully, but these errors were encountered: