Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores and code hygiene #4968

Open
2 of 37 tasks
compulim opened this issue Nov 26, 2023 · 0 comments
Open
2 of 37 tasks

Chores and code hygiene #4968

compulim opened this issue Nov 26, 2023 · 0 comments
Labels
feature-request Azure report label

Comments

@compulim
Copy link
Contributor

compulim commented Nov 26, 2023

Is your feature request related to a problem?

We need to update Web Chat to clear up some chores and code hygiene. This is a non-exhaustive list.

Describe the suggestion or request in detail

Notes: Mutex = when this work is started, will block all other works

Describe alternatives you have considered

No response

Additional context

No response

@compulim compulim added the feature-request Azure report label label Nov 26, 2023
OEvgeny added a commit to OEvgeny/BotFramework-WebChat that referenced this issue Dec 20, 2023
Address the first 3 suggestions from microsoft#4968

As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to:
- Serve as an additional hint that the function follows React Component signature
- Limit usage of unsupported by React runtime return types
OEvgeny added a commit that referenced this issue Jan 10, 2024
Address the first 3 suggestions from #4968

As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to:
- Serve as an additional hint that the function follows React Component signature
- Limit usage of unsupported by React runtime return types
OEvgeny added a commit that referenced this issue Jan 19, 2024
Address the first 3 suggestions from #4968

As we remove `FC/VFC` I thought it'd be nice to add `ReactNode` return type basically to:
- Serve as an additional hint that the function follows React Component signature
- Limit usage of unsupported by React runtime return types
@compulim compulim pinned this issue May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Azure report label
Projects
None yet
Development

No branches or pull requests

1 participant