Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tech debt to consider/ prioritize #23

Open
d-callan opened this issue Mar 13, 2024 · 1 comment
Open

Some tech debt to consider/ prioritize #23

d-callan opened this issue Mar 13, 2024 · 1 comment

Comments

@d-callan
Copy link
Collaborator

the Collection constructors should take a single object rather than three and work like collectionBuilder currently does

consider how to improve manual mapping of things like 'MetagenomicAssay' to 'WGS'.. internally called dataSourceName here

there are a number of *Builder functions that could probably be proper S4 methods or constructors or something

@d-callan
Copy link
Collaborator Author

on the subject of the mapping of things like 'MetagenomicAssay' to 'WGS'.. what im currently doing didnt work for uganda maternal, bc that study has two different 16s assay entities for different regions. we should be careful to handle that case well when we get to this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant