Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify bison files to require minimum version #128

Open
dowobeha opened this issue Jun 26, 2021 · 5 comments
Open

Modify bison files to require minimum version #128

dowobeha opened this issue Jun 26, 2021 · 5 comments

Comments

@dowobeha
Copy link
Contributor

On macOS, bison is present but is an ancient version. On macOS 10.15.7, the version of bison is 2.3.

As a result, some of the newer fixes to bison files use syntax that bison 2.3 doesn't recognize, resulting in bison syntax errors.

Bison supports marking a minimum required version.

There are two options. One is rewriting the bison files to support bison 2.3 syntax. While this would be nice for those of us on macOS, a simpler solution would be to use the bison require syntax to require a specific version of bison.

@AmbientLighter
Copy link
Contributor

Hi,
Package for macOS is built without errors on macOS 10.15.7
Here's log: https://github.com/mhulden/foma/runs/2773115543
and ZIP archive: https://github.com/mhulden/foma/suites/2939992105/artifacts/66053844

@pemistahl
Copy link

@dowobeha is right. Foma builds on macOS in your CI pipeline only because the most current version of bison is installed via Homebrew.

@AmbientLighter Can't you just extend your CI pipeline to put the compiled binaries as attachments on a tagged release? It would be really helpful if you created tagged releases when you finish a new version. This way, users would not have to compile from source themselves.

@AmbientLighter
Copy link
Contributor

AmbientLighter commented Jun 29, 2021

@pemistahl I'm not a maintainer of foma, so I've asked @mhulden to tag releases or grant me a permissions.
See also: #93
Unfortunately, he didn't respond to any comments or requests.
Surely, I can tag releases in my own fork, but I'm not really sure whether it would do more harm than good.

@AmbientLighter
Copy link
Contributor

See also: https://github.com/AmbientLighter/foma/releases/tag/0.10.0

@pemistahl
Copy link

Fair enough, @AmbientLighter. Thank you for the compiled binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants