Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove testing dependencies from library dependencies #59

Open
agrafix opened this issue Jun 22, 2016 · 5 comments
Open

Remove testing dependencies from library dependencies #59

agrafix opened this issue Jun 22, 2016 · 5 comments

Comments

@agrafix
Copy link

agrafix commented Jun 22, 2016

Thanks for this awesome library!

Are there any plans to remove hspec and friends from the library dependencies?

@Blaisorblade
Copy link

Yes please @mgsloan. Even installing stack requires hspec and related libs. And any client of store has to be built with the same version hspec as store, possibly requiring more recompilation for cabal-install users.

However, this is not so easy because of the use in Data.Store.TH, but that arguably belongs to a smaller store-hspec package. That's probably used in its own testsuite though, making the split a bit harder?
https://github.com/fpco/store/blob/ad2af60f1f65132c2a5b069f938ca25423a4b3e8/src/Data/Store/TH.hs

@mgsloan
Copy link
Owner

mgsloan commented Aug 8, 2016

I think it makes sense to split off a store-test package, which does the following:

  1. Defines utilities for conveniently defining tests for store instances
  2. Has the store test-suite

@sol
Copy link

sol commented Sep 28, 2017

@mgsloan As a first step, wouldn't it make sense to just move the test dependencies from top-level to the test suite (haven't looked at it).

@sol
Copy link

sol commented Sep 28, 2017

it also provides utilities for checking them via smallcheck and hspec

@mgsloan disregard what I said before, I just read your blog post. Makes sense now.

@mgsloan
Copy link
Owner

mgsloan commented Sep 28, 2017

Cool! Though, I am willing to revisit this if it helps make store more useful to people.

Could split things out into a store-test package, as described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants